While evaluating this module I noticed that on the Extend page, the project name is in lower case and should be in title case to be consistent with the rest of the project names on the page.

"Capitalize the name of the module, because module names are proper nouns."

https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

CommentFileSizeAuthor
#7 devel-capitalize-name-3003353-7.patch1.75 KBStacie_A
#5 after.png4.15 KBajlib
#5 before.png3.96 KBajlib
#3 devel-capitalize-name-3003353-3.patch394 bytesStacie_A
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkswagenchick created an issue. See original summary.

Stacie_A’s picture

Stacie_A CreditAttribution: Stacie_A as a volunteer and at Madison Area Technical College commented
Assigned: Unassigned » Stacie_A

I'll work on this patch.

Stacie_A’s picture

Stacie_A CreditAttribution: Stacie_A as a volunteer and at Madison Area Technical College commented
Assigned: Stacie_A » Unassigned
FileSize
devel-capitalize-name-3003353-3.patch394 bytes

I capitalized the name of the submodule in the info.yml to Devel Generate

Stacie_A’s picture

Stacie_A CreditAttribution: Stacie_A as a volunteer and at Madison Area Technical College commented
Status: Active » Needs review
ajlib’s picture

ajlib CreditAttribution: ajlib commented
Status: Needs review » Reviewed & tested by the community
FileSize
before.png3.96 KB
after.png4.15 KB

I spun up the module before the patch and 'generate' was not capitalized. Then I tested with the patch and it was capitalized. The patch was applied with simplytest.me.

Screenshot attached.

salvis’s picture

salvis
he/his
CreditAttribution: salvis as a volunteer commented

Let's see them...

Before: (before)

After: (after)

Is this really the only place where we use a submodule name?

Stacie_A’s picture

Stacie_A CreditAttribution: Stacie_A as a volunteer and at Madison Area Technical College commented
FileSize
devel-capitalize-name-3003353-7.patch1.75 KB

Good point, @salvis

Ok, I ran grep -rnw 'Devel generate' . in the Devel directory and found 2 more places to fix. 

./modules/devel/devel_generate/tests/modules/devel_generate_example/devel_generate_example.info.yml:1:name: 'Devel generate Example'
./modules/devel/devel_generate/README.txt:41:Devel generate automatically use the values returned by this method during the

running grep -rnw 'Devel generate' . after fixes returned no additional results.

  • salvis committed 46ab119 on 8.x-1.x 
    Issue #3003353 by Stacie_A: Capitalize the Devel Generate module name.
salvis’s picture

salvis
he/his
CreditAttribution: salvis as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Great, thank you, Stacie_A!

I added two minor grammar fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.