These two classes are using each other, and it would make sense to reduce their dependencies. All we need to do is to move the index writing code to XmlSitemapGenerator, and then they are no longer inter-dependent.

CommentFileSizeAuthor
#9 3002605-refactor-generate-writer.patch24.97 KBDave Reid
#8 3002605-refactor-generate-writer.patch22.9 KBDave Reid
#6 3002605-refactor-generate-writer.patch21.92 KBDave Reid
#4 3002605-refactor-generate-writer.patch21.85 KBDave Reid
#2 3002605-refactor-generate-writer.patch21.83 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid created an issue. See original summary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Active » Needs review
FileSize
3002605-refactor-generate-writer.patch21.83 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3002605-refactor-generate-writer.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
3002605-refactor-generate-writer.patch21.85 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3002605-refactor-generate-writer.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
3002605-refactor-generate-writer.patch21.92 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3002605-refactor-generate-writer.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
3002605-refactor-generate-writer.patch22.9 KB
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
FileSize
3002605-refactor-generate-writer.patch24.97 KB

Final version.

  • Dave Reid committed a9490a1 on 8.x-1.x 
    Issue #3002605 by Dave Reid: Refactor XmlSitemapWriter to not reverse...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Version: 8.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Patch (to be ported)

Some of this can be ported to 7.x-2.x as well.