Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
\Drupal\node\NodeViewsData
provides a custom join from the revision data table to the data table, which shouldn't be needed because \Drupal\views\EntityViewsData
already has it:
// Join the revision table to the base table.
$data[$views_revision_base_table]['table']['join'][$views_base_table] = [
'left_field' => $revision_field,
'field' => $revision_field,
'type' => 'INNER',
];
Proposed resolution
Remove the unneeded custom join.
Remaining tasks
Review.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3002158.patch | 775 bytes | amateescu |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedHere we go.
Comment #3
timmillwoodClean up is always good!
Comment #4
jibranComment #5
catchCommitted 4aba93b and pushed to 8.7.x. Thanks!