Problem/Motivation

\Drupal\node\NodeViewsData provides a custom join from the revision data table to the data table, which shouldn't be needed because \Drupal\views\EntityViewsData already has it:

      // Join the revision table to the base table.
      $data[$views_revision_base_table]['table']['join'][$views_base_table] = [
        'left_field' => $revision_field,
        'field' => $revision_field,
        'type' => 'INNER',
      ];

Proposed resolution

Remove the unneeded custom join.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#2 3002158.patch775 bytesamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

Status: Active » Needs review
FileSize
775 bytes

Here we go.

timmillwood’s picture

Status: Needs review » Reviewed & tested by the community

Clean up is always good!

jibran’s picture

Issue tags: +VDC
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4aba93b and pushed to 8.7.x. Thanks!

  • catch committed 4aba93b on 8.7.x
    Issue #3002158 by amateescu: Clean up dead code in NodeViewsData
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.