The "View all draft change records" link is invalid
the link is on Draft change record nodes, for example here: https://www.drupal.org/node/3001550

Currently the link points to https://www.drupal.org/list-changes/drafts . The correct link for Drupal project should be: https://www.drupal.org/list-changes/drupal/drafts

The "View all published change records" link should contain the project name, as such link in a contrib module change record, points to the Drupal core changes now.

The link is created in drupalorg_change_notice.module. Seems like all the links in the module file should be updated to include the project name.

CommentFileSizeAuthor
#7 wrong-link-on-change-record-3001634-7.patch1.91 KBmsankhala
#3 3001634-3.patch1.55 KBhardikpandya

Comments

Pasqualle created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
commented
Parent issue: » #1217118: [meta] Followups for API change nodes
Related issues: +#2302003: Change records tabs for contrib projects link to Drupal core's change records

Confirmed this is an issue, which needs to be fixed in 2 places:

features/drupalorg_change_notice/drupalorg_change_notice.module
14:      drupal_set_message(t('Created draft change record. <a href="@url">View all draft change records</a>.', array('@url' => url('list-changes/drafts'))));
48:          $output['field_change_record_status'][0]['#suffix'] = ' (' . t('<a href="@url">View all draft change records</a>', array('@url' => url('list-changes/drafts'))) . ')';
hardikpandya’s picture

hardikpandya commented
Status: Active » Needs review
StatusFileSize
new 3001634-3.patch1.55 KB
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

Thanks for the patch!

Change records are not just for the drupal core project, all projects may use them. Something like $node_wrapper->field_project->field_project_machine_name->value(); should get the right value.

Working on this without running the code isn’t great. We have Drupal.org dev sites if you would like to use one for this: https://www.drupal.org/drupalorg/docs/build/development-environments/dev...

msankhala’s picture

msankhala commented
Assigned: Unassigned » msankhala

Working on it.

drumm’s picture

drumm
he/him
Location NY, US
commented

changerecord-drupal.dev.devdrupal.org is building out for this, and should complete within 45 minutes.

msankhala’s picture

msankhala commented
Status: Needs work » Needs review
StatusFileSize
new wrong-link-on-change-record-3001634-7.patch1.91 KB

Here is the updated patch as per suggestion by @drumm in #4.

Created one test change record for paragraph module https://changerecord-drupal.dev.devdrupal.org/node/3002976
List of change records for paragraph module https://changerecord-drupal.dev.devdrupal.org/list-changes/1491122/drafts

  • drumm committed afa7f99 on 7.x-3.x, dev authored by msankhala 
    Issue #3001634 by msankhala, hardikpandya: Wrong link on change record
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Thanks! This has been deployed to Drupal.org.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.