Just upgraded the Aegir Debian package (unstable channel), and noticed this:

[...] nginx on hostname has been restarted [success]
Created directory /var/aegir/hostmaster-7.x-3.x-2018-09-20-1200/sites/all/drush. [success]
Generated config in write(): Platform Drush configuration file [success]
(/var/aegir/hostmaster-7.x-3.x-2018-09-20-1200/sites/all/drush/drushrc.php)
Changed permissions of [success]
/var/aegir/hostmaster-7.x-3.x-2018-09-20-1200/sites/all/drush/drushrc.php to 444
Platforms path /var/aegir/platforms exists. [success]
Platforms ownership of /var/aegir/platforms has been changed to aegir. [success]
Platforms permissions of /var/aegir/platforms have been changed to 755. [success]
Platforms path /var/aegir/platforms is writable. [success]
ArgumentCountError: Too few arguments to function drush_hosting_pause_validate(), 0 passed in phar:///usr/local/bin/drush/includes/command.inc on line 422 and exactly 1 expected in drush_hosting_pause_validate() (line 11 of /var/aegir/hostmaster-7.x-3.x-2018-08-02-1559/profiles/hostmaster/modules/aegir/hosting/pause.hosting.inc).
 7.59

Changed group ownership of /var/aegir/hostmaster-7.x-3.x-2018-08-02-1559/sites/dev.aegir.hiberdata.com/local.settings.php to www-data [success] [...]

Not sure from where the problem is coming, but everything seems to be working properly.

Comments

colan created an issue. See original summary.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Project: Provision » Hosting
Component: Drush integration » Code

This function is actually a part of Hosting: https://cgit.drupalcode.org/hosting/tree/pause.hosting.inc.

The argument ("$url") doesn't appear to be used in the function.

It's defined here: https://github.com/aegir-project/hosting/blob/7.x-3.x/hosting.drush.inc#L78

But, AFAICT, it only appears to be called here: https://github.com/aegir-project/provision/blob/7.x-3.x/migrate.hostmast...

I *believe* that we can just drop the argument from the Drush command definition and the function calls. But it's possible that we're retrieving it with drush_get_argument() or something deeper into the call stack.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented

That $url argument looks unused, so +1 for removing it... while looking into pause.hosting.inc I just found an old 'quickreview' branch that removes it.

  • helmo committed 12af4c0 on 7.x-3.x 
    Issue #3001273: Too few arguments to function...
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.