#2997736: Fix tests fails in 8.x-2.x caused a regression.

The problem is that the selector above also seems to be match the hidden path element and then that doesn't have a data-uuid attribute. Before that apparently didn't matter because clicking that didn't do anything but now it assumes that it has this attribute.

CommentFileSizeAuthor
#4 entity-browser-2998317-data-selector-4.patch2.73 KBberdir
#2 entity-browser-2998317-data-selector-2.patch1.3 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new entity-browser-2998317-data-selector-2.patch1.3 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

This is actually not a complete fix yet, as iframe is also hardcoded there explicitly in the drupal settings array, didn't realize that before.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new entity-browser-2998317-data-selector-4.patch2.73 KB

Maybe the easiest fix is to promote the open setting one level up, as there are already some settings there while others are inside iframe/modal.

miiimooo’s picture

miiimooo
Location Europe
commented

Fixed this #3027524: Replace inside paragraphs field breaks when pressing Replace for me but there is a remaining issue that when I cancel the selection the old image/media reference is removed.

I think it should keep the original reference in that case.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@miiimooo, yeah that is a limitation, technically, replace currently is just delete + select combined into a single action, it's not so easy to change that. That not really related to this issue so, so I'd suggest you create a separate issue for that, but we don't have any plans to work on that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Priority: Normal » Major

  • Primsi committed 5f653e4 on 8.x-2.x authored by Berdir 
    Issue #2998317 by Berdir: Improve replace selector  to make sure it...

  • Primsi committed 3110ea4 on 8.x-1.x authored by Berdir 
    Issue #2998317 by Berdir: Improve replace selector  to make sure it...
primsi’s picture

primsi commented
Status: Needs review » Fixed

Commited. Thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.