Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Similar to the radios issue which was recently fixed. I have tested this patch in Drupal 6.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | form.inc-299742-2_HEAD.patch | 1.03 KB | Darren Oh |
| #2 | form.inc-299742-2_DRUPAL-6.patch | 1.04 KB | Darren Oh |
| form.inc_DRUPAL-6.patch | 1.01 KB | Darren Oh | |
| form.inc-HEAD.patch | 1 KB | Darren Oh | |
Comments
Comment #1
fuerst CreditAttribution: fuerst commentedHaving #ahah working for #type checkboxes is a nice addition.
form.inc_DRUPAL-6.patch against Drupal 6.5 succeeded and works as advertised.
Had no chance to test using HEAD yet.
How to proceed to get this included into core?
Comment #2
Darren OhWell, the patches needed to be updated to match the latest core versions. In your next reply, set this issue to "reviewed and tested". The patches are exceedingly simple (and identical to the one used to fix radio boxes), so don't worry if someone scolds you for changing the status.
Comment #3
fuerst CreditAttribution: fuerst commentedBoth patches succeeded using Drupal 6.5 / Drupal 7-dev.
I validated the functionality using Drupal 6.5.
So, it's ready to be included into the next release, hopefully.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HAED hit.
Comment #5
yang_yi_cn CreditAttribution: yang_yi_cn commentedI'm not sure if I'm doing correctly, but I tested it and it's not working. The patch was applied with not warnings, but the checkboxes still doesn't work for #ahah.
I tried to add a checkboxes widget by ahah. The submission is by click a button with #ahah property, and if I insert a textfield or select, it works as expected, but if I try to insert a checkboxes widget, it only shows the rendered checkboxes form-item, not any of the options. I tried to trace the code and find expand_checkboxes() in form.inc is not even getting called. Is it the same issue of the patch trying to fix or another issue?
Comment #6
Darren OhThat's a different problem. This patch lets you make checkboxes do things when you click on them.
Comment #7
Darren OhOops. Already ported. Just needs to be committed.
Comment #8
Gábor HojtsyLooks good, reviewed and committed to 6.x! Thanks.
Comment #10
Alex Savin CreditAttribution: Alex Savin commentedStill I can not get ahah to create dynamic checkboxes elements. If I change the type of the element in select than everything works ok.
Comment #11
Darren OhPlease see comment #6.