Continue drush 8 support (was Migrate Upgrade rc5 seems not to work) [#2996962]

Hi,

I'm using this module to migrate my D6 website, into 2 different website.
One use the 8.x-3.0-rc4 version and the other one 8.x-3.0-rc5.
The second one doesn't accept to create new migrations from fresh install..th eother one work as designed.

drush debug code:

Drush bootstrap phase : bootstrap_drupal_database() [0.21 sec, 8.58 MB]                                                                                               [bootstrap]
Successfully connected to the Drupal database. [0.21 sec, 8.58 MB]                                                                                                    [bootstrap]
Find command files for phase 4 (max=5) [0.21 sec, 8.58 MB]                                                                                                                [debug]
Drush bootstrap phase : bootstrap_drupal_full() [0.21 sec, 8.58 MB]                                                                                                   [bootstrap]
About to bootstrap the Drupal 8 Kernel. [0.21 sec, 8.59 MB]                                                                                                               [debug]
Finished bootstraping the Drupal 8 Kernel. [0.27 sec, 16.92 Mo]                                                                                                           [debug]
Cache HIT cid: 8.1.16-install_profile-6dfce66ee85e248453041340113581eb [0.3 sec, 17.89 Mo]                                                                                [debug]
Find command files for phase 5 (max=5) [0.3 sec, 17.99 Mo]                                                                                                                [debug]
Cache HIT cid: 8.1.16-install_profile-6dfce66ee85e248453041340113581eb [0.3 sec, 17.99 Mo]                                                                                [debug]
Cache HIT cid: 8.1.16-commandfiles-5-849c8b6353def1ac8eb3c9dbbacd8c9a [0.31 sec, 18.38 Mo]                                                                                [debug]
Find command files for phase 2 (max=3) [1.26 sec, 21.5 Mo]                                                                                                                [debug]
Cache HIT cid: 8.1.16-install_profile-6dfce66ee85e248453041340113581eb [1.26 sec, 21.5 Mo]                                                                                [debug]
Cache HIT cid: 8.1.16-commandfiles-2-de9e51bda4b04a9491378098baf75267 [1.26 sec, 21.51 Mo]                                                                                [debug]
Command migrate-upgrade needs the following extension(s) enabled to run: migrate_upgrade. [1.91 sec, 23 Mo]                                                           [error]
The drush command 'migrate-upgrade' could not be executed. [1.92 sec, 23 Mo]

Is there a bug ?

Thanks

Comment	File	Size	Author
#6	Migrate_upgrade_rc5_seem_not_to_work-29196962-6.patch	775 bytes	stefan.korn

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 September 2018 at 14:06

aiphes created an issue. See original summary.

Comment #2

aiphes

French

CreditAttribution: aiphes commented 3 September 2018 at 14:28

Issue summary:

View changes

Comment #3

longwave

he/him

English

CreditAttribution: longwave as a volunteer commented 3 September 2018 at 16:10

Project:	Drupal core	» Migrate Upgrade
Version:	8.5.6	» 8.x-3.0-rc5
Component:	migration system	» Code

Moving this to the Migrate Upgrade queue, as this doesn't seem to be an issue for Drupal core.

Comment #4

stefan.korn

German

Jossgrund

CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented 11 September 2018 at 13:30

What version of drush are you using?

Comment #5

phuang07 CreditAttribution: phuang07 as a volunteer commented 11 September 2018 at 19:39

I have issue in rc5 as well. Rc4 is ok.

⟩ drush migrate-upgrade --configure-only --legacy-db-key=migrate
Error: Call to undefined method Drush\Sql\SqlBase::dbSpecFromDbUrl() in                                 [error]
Drupal\migrate_upgrade\MigrateUpgradeDrushRunner->configure() (line 131 of
/var/www/web/modules/contrib/migrate_upgrade/src/MigrateUpgradeDrushRunner.php) #0
/var/www/web/modules/contrib/migrate_upgrade/migrate_upgrade.drush.inc(50):
Drupal\migrate_upgrade\MigrateUpgradeDrushRunner->configure()
#1 /var/www/vendor/drush/drush/includes/command.inc(422): drush_migrate_upgrade()
#2 /var/www/vendor/drush/drush/includes/command.inc(231): _drush_invoke_hooks(Array, Array)
#3 /var/www/vendor/drush/drush/includes/command.inc(199): drush_command()
#4 /var/www/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch(Array)
#5 /var/www/vendor/drush/drush/includes/preflight.inc(66): Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#6 /var/www/vendor/drush/drush/drush.php(12): drush_main()
#7 {main}.
Error: Call to undefined method Drush\Sql\SqlBase::dbSpecFromDbUrl() in /var/www/web/modules/contrib/migrate_upgrade/src/MigrateUpgradeDrushRunner.php on line 131 #0 /var/www/web/modules/contrib/migrate_upgrade/migrate_upgrade.drush.inc(50): Drupal\migrate_upgrade\MigrateUpgradeDrushRunner->configure()
#1 /var/www/vendor/drush/drush/includes/command.inc(422): drush_migrate_upgrade()
#2 /var/www/vendor/drush/drush/includes/command.inc(231): _drush_invoke_hooks(Array, Array)
#3 /var/www/vendor/drush/drush/includes/command.inc(199): drush_command()
#4 /var/www/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch(Array)
#5 /var/www/vendor/drush/drush/includes/preflight.inc(66): Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#6 /var/www/vendor/drush/drush/drush.php(12): drush_main()
#7 {main}
Error: Call to undefined method Drush\Sql\SqlBase::dbSpecFromDbUrl() in Drupal\migrate_upgrade\MigrateUpgradeDrushRunner->configure() (line 131 of /var/www/web/modules/contrib/migrate_upgrade/src/MigrateUpgradeDrushRunner.php).
Drush command terminated abnormally due to an unrecoverable error.

Comment #6

stefan.korn

German

Jossgrund

CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented 12 September 2018 at 04:15

Title:	Migrate Update rc5 seem to not work	» Migrate Upgrade rc5 seems not to work
Related issues:		+#2915726: Drush 9 port of commands

File	Size
Migrate_upgrade_rc5_seem_not_to_work-29196962-6.patch	775 bytes

@ph53: This is probably related to your drush version. RC5 is currently not working with drush version 8, only version 9.

Check if it works for you with this patch.

Comment #7

stefan.korn

German

Jossgrund

CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented 12 September 2018 at 04:16

Status:

Active

» Needs review

Comment #8

aiphes

French

CreditAttribution: aiphes commented 12 September 2018 at 08:03

So it's normal behaviour as I'm using Drush Version : 8.1.16
If Drush 8 doesn't work with rc5, a warning to no update would be great on the module page.

Comment #9

phuang07 CreditAttribution: phuang07 as a volunteer commented 12 September 2018 at 15:20

@stefan.korn
The patch #6 is not working.

⟩ drush migrate-upgrade --configure-only --legacy-db-key=migrate
Driver not specified for this database connection: upgrade                                              [error]

Comment #10

stefan.korn

German

Jossgrund

CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented 12 September 2018 at 16:04

Ok, I think there is another issue with the "legacy-db-key" parameter that is not related to this issue. Will try to sort this out.

Comment #11

stefan.korn

German

Jossgrund

CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented 12 September 2018 at 16:13

@ph53: Could you please try and use patch from here too: https://www.drupal.org/project/migrate_upgrade/issues/2999099#comment-12...

This fixes a general issue with the "legacy-db-key" option, that affects the module as a whole not only regarding Drush version.

Comment #12

designcrs CreditAttribution: designcrs commented 23 September 2018 at 14:55

@stefan.korn:
Applying #6 https://www.drupal.org/project/migrate_upgrade/issues/2996962#comment-12...
and https://www.drupal.org/project/migrate_upgrade/issues/2999099#comment-12...
has fixed the problem.

I can now run "drush migrate-upgrade" for my D6 site again!

Thank you!

Comment #13

rwmanos CreditAttribution: rwmanos commented 24 September 2018 at 10:21

Running migrate-upgrade with Drush 8.1.15 gives Call to undefined method Drush\Sql\SqlBase::dbSpecFromDbUrl() error.

Applying both patches listed in #12 seem to fix the issue so thank you all for providing a solution. However, I still believe this is extremely inconvenient and the functionality should not break with a regular module update (in rc state already).

Comment #14

heddn

English

Nicaragua

CreditAttribution: heddn at MTech, LLC, Acro Commerce commented 22 October 2018 at 14:59

Title:	Migrate Upgrade rc5 seems not to work	» Drush 8 support (was Migrate Upgrade rc5 seems not to work)
Status:	Needs review	» Reviewed & tested by the community

Ideally, folks will upgrade to Drush 9 as 8 hasn't been supported on Drupal since 8.3. See http://docs.drush.org/en/master/install/#drupal-compatibility.

But this is a simple fix. So committing.

Comment #15

22 October 2018 at 15:00

heddn committed 5b8c114 on 8.x-3.x authored by stefan.korn

Issue #2996962 by stefan.korn, heddn: Continue drush 8 support (was...

Comment #16

heddn

English

Nicaragua

CreditAttribution: heddn at MTech, LLC, Acro Commerce commented 22 October 2018 at 15:00

Title:	Drush 8 support (was Migrate Upgrade rc5 seems not to work)	» Continue drush 8 support (was Migrate Upgrade rc5 seems not to work)
Status:	Reviewed & tested by the community	» Fixed

Comment #17

aiphes

French

CreditAttribution: aiphes commented 29 October 2018 at 10:16

D8.6.2 seem not to fix the issue, RC5 can be enabled.But when I do drush @site migrate-upgrade XXXXX --configure-only I get th error

Fatal error: Call to undefined method Drush\Sql\SqlBase::dbSpecFromDbUrl() in /home/www/xxx/sited8/modules/contrib/migrate_upgrade/src/MigrateUpgradeDrushRunner.php on line 131
Drush command terminated abnormally due to an unrecoverable error.

Comment #18

heddn

English

Nicaragua

CreditAttribution: heddn at MTech, LLC, Acro Commerce commented 29 October 2018 at 16:00

You have to upgrade from the tag rc5 to the dev branch of this module.

Comment #19

12 November 2018 at 16:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #20

aiphes

French

CreditAttribution: aiphes commented 22 May 2019 at 14:26

Just a feedback on another migration using v3.0 and RC4 with Drush 8.
Result is the same: Group: Import from Drupal 6 (migrate_drupal_6) is created, and default group is partially created.
If I re-run the command I get:

drush @vmdevd8mg migrate-upgrade --legacy-db-url=mysqlXXXXX --configure-only
'migration_group' entity with ID 'migrate_drupal_6' already exists.

Will it be an issue when I will an update of migrations to get back content created between 2 migrations ?
Could it be a memory limit ou time limit of the connexion to the server ?