See #2848161: [meta] Replace calls to deprecated db_*() wrappers

CommentFileSizeAuthor
#9 2996441-9.patch6.88 KBlongwave
#6 2996441-6.patch6.88 KBandypost
#6 interdiff.txt720 bytesandypost
#2 2996441-2.patch6.87 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
2996441-2.patch6.87 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Parent issue: » #2848161: [meta] Replace calls to deprecated db_*() wrappers
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Looks good

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
@@ -2,15 +2,44 @@
+   * Constructs a CommentController object.

Copy/paste error.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
FileSize
interdiff.txt720 bytes
2996441-6.patch6.88 KB

Fixed

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2996441-6.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs work » Needs review
FileSize
2996441-9.patch6.88 KB

Rerolled.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d122ac7 and pushed to 8.7.x. Thanks!

  • catch committed d122ac7 on 8.7.x 
    Issue #2996441 by andypost, longwave: Replace all calls to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.