Updating a site using Drush gives the following warning with PHP 7.2

Use of undefined constant XMLSITEMAP_BATCH_LIMIT - assumed 'XMLSITEMAP_BATCH_LIMIT' (this will throw an Error in a future version of PHP) xmlsitemap.drush.inc:33

CommentFileSizeAuthor
#7 xmlsitemap-undefined_constant-2996092-7.patch681 bytespifagor
#4 xmlsitemap-undefined_constant-2996092-4.patch358 bytestoomanypets
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ac created an issue. See original summary.

dgtlmoon’s picture

dgtlmoon CreditAttribution: dgtlmoon commented

+1 here

toomanypets’s picture

toomanypets CreditAttribution: toomanypets commented

See #2939318-3: Updated xmlsitemap.drush.inc causes install to fail on aegir for possible fix.

toomanypets’s picture

toomanypets CreditAttribution: toomanypets commented
FileSize
xmlsitemap-undefined_constant-2996092-4.patch358 bytes
toomanypets’s picture

toomanypets CreditAttribution: toomanypets commented
Status: Active » Needs review
ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented
Status: Needs review » Reviewed & tested by the community

Works

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Version: 7.x-2.5 » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
FileSize
xmlsitemap-undefined_constant-2996092-7.patch681 bytes

I think we can move the constant XMLSITEMAP_BATCH_LIMIT

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB for GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Looks good.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented

  • pifagor committed f097fd2 on 7.x-2.x 
    Issue #2996092 by toomanypets, pifagor, ac, dgtlmoon, alex_optim: Use of...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed
howdytom’s picture

howdytom CreditAttribution: howdytom as a volunteer commented

Thank you, pifagor! #7 patch works for me too. Well done. Error message disappears.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.