Automatically order facet parameters in query string to reduce cache permutations.

Order the paramets in the url to be ordered alphabetically.

CommentFileSizeAuthor
#6 2995806.patch3.47 KBborisson_
#6 interdiff-2995806.txt3.5 KBborisson_
#5 interdiff-2995806.txt1.86 KBborisson_
#5 2995806.patch2.4 KBborisson_
#3 facets-order-query-parameters-alphabetically-2995806-3.patch556 byteswaluigi
#3 facets-order-parameters-alphabetically-2995806-3.patch556 byteswaluigi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

waluigi’s picture

waluigi CreditAttribution: waluigi at Unic commented
Assigned: Unassigned » waluigi

I'll give it a shot :)

waluigi’s picture

waluigi CreditAttribution: waluigi at Unic commented
Status: Active » Needs review
FileSize
facets-order-parameters-alphabetically-2995806-3.patch556 bytes
facets-order-query-parameters-alphabetically-2995806-3.patch556 bytes

Now it simply sorts the variable $filter_params in QueryString.php using the sort function.

It does not work when using pretty paths. @borisson_ should it be implemented in there as well?

waluigi’s picture

waluigi CreditAttribution: waluigi at Unic commented

I accidentally uploaded the same patch twice, only the name is different.

Sorry for that :)

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
FileSize
2995806.patch2.4 KB
interdiff-2995806.txt1.86 KB

It does not work when using pretty paths. @borisson_ should it be implemented in there as well?

Yes, this will be a completely different implementation. Probably in the url plugin they provide, I'm assuming that will harder to write though.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
FileSize
interdiff-2995806.txt3.5 KB
2995806.patch3.47 KB

The tests should be green.

  • borisson_ committed 6708fa6 on 8.x-1.x 
    Issue #2995806 by borisson_, waluigi: Automatically order facet...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Needs review » Fixed

Committed and pushed, thanks for the help @waluigi!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.