Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Re-installing the media library doesn't work, because of the following error:
Unable to install Media library, core.entity_form_mode.media.media_library already exists in active configuration.
Proposed resolution
Add an enforced dependency of media_library to core.entity_form_mode.media.media_library
Comment | File | Size | Author |
---|---|---|---|
#9 | 2989884-9.patch | 2.18 KB | alexpott |
#9 | 6-9-interdiff.txt | 3.66 KB | alexpott |
#9 | 2989884-9.test-only.patch | 1.62 KB | alexpott |
#6 | interdiff-2989884-5-6.txt | 795 bytes | chr.fritsch |
#6 | 2989884-6.patch | 2.59 KB | chr.fritsch |
Comments
Comment #2
chr.fritschHere are a fail patch and a patch with the fix.
Comment #4
phenaproximaLooks good to me, only found a few issues...
Should be "install" and "uninstall" (no capitalization).
Should be protected.
Why not use the UI to uninstall the module?
Should use existing $assert_session variable.
Comment #5
chr.fritschThanks for reviewing, @phenaproxima
Here are the fixes.
Comment #6
chr.fritschLost the changes for #4.1 and #4.2 during patch-creation...
So here is a new one and also uploaded a fail patch again.
Comment #7
phenaproximaLooks great. RTBC once the true patch is green on all backends.
Comment #9
alexpottHere's a better test that means this won't happen in core again.
Comment #11
chr.fritschThat makes much more sense 👍
@alexpott++
Comment #12
alexpottCommitted and pushed d712f83e2c to 8.7.x and 0fc35d3efc to 8.6.x. Thanks!
Backported to 8.6.x because media library is an experimental module and this fix puts it in better shape for 8.6.0.