Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Since SA-CONTRIB-2018-053 is committed in the 7.x-2.x-dev branch, tests fail.
The following tests fail since the security update:
- testNodeSettings
- testTypeSettings
- testCron
This should be fixed ASAP since no feature or bugfix release will take place unless all tests pass.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2989571-3-fix-tests-xmlsitemap-node.patch | 3.19 KB | sjerdo |
| |||
#3 | interdiff-2989571-2-3.txt | 639 bytes | sjerdo |
Comments
Comment #2
sjerdoAdded a patch which runs the cron after each node insert and update.
Also updated testCron since nodes are added in chronological order since they are added in a queue.
Comment #3
sjerdoUpdated patch. testCron test was incorrect while the nodes were popped from the array instead of shifted.
Comment #5
sjerdoWell, I did some debugging and it seems like the node xmlsitemap override options (on node edit page) are no longer working since the security update.
Originally the node update (hook xmlsitemap_node_node_update) would include the changed/overridden xmlsitemap settings and save them instantly.
Since the queue is introduced, only the node id is passed to the cron. In the cron the current (non-changed) settings are loaded in method xmlsitemap_node_create_link. Custom changes to the XML sitemap link for the node are dropped/ignored.
The same applies for creating a new node. The default settings for the node always are applied for a new node.
I guess we need a follow-up issue for this bug.
edit: This bug is already reported in #2987125: After updating from 7.x-2.3 to 7.x-2.4 Content Inclusion Options NOT Saving.
Comment #6
sjerdoComment #7
sjerdoComment #8
sjerdoTests pass since #2987125: After updating from 7.x-2.3 to 7.x-2.4 Content Inclusion Options NOT Saving has been committed to 7.x-2.x-dev
Comment #9
joegraduateTest changes look good to me. A new bug fix release is needed ASAP.
Comment #10
pifagorComment #12
pifagor