Since SA-CONTRIB-2018-053 is committed in the 7.x-2.x-dev branch, tests fail.

The following tests fail since the security update:

  • testNodeSettings
  • testTypeSettings
  • testCron

This should be fixed ASAP since no feature or bugfix release will take place unless all tests pass.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sjerdo created an issue. See original summary.

sjerdo’s picture

Status: Active » Needs review
FileSize
3.18 KB

Added a patch which runs the cron after each node insert and update.
Also updated testCron since nodes are added in chronological order since they are added in a queue.

sjerdo’s picture

Updated patch. testCron test was incorrect while the nodes were popped from the array instead of shifted.

Status: Needs review » Needs work

The last submitted patch, 3: 2989571-3-fix-tests-xmlsitemap-node.patch, failed testing. View results

sjerdo’s picture

Well, I did some debugging and it seems like the node xmlsitemap override options (on node edit page) are no longer working since the security update.

Originally the node update (hook xmlsitemap_node_node_update) would include the changed/overridden xmlsitemap settings and save them instantly.
Since the queue is introduced, only the node id is passed to the cron. In the cron the current (non-changed) settings are loaded in method xmlsitemap_node_create_link. Custom changes to the XML sitemap link for the node are dropped/ignored.
The same applies for creating a new node. The default settings for the node always are applied for a new node.

I guess we need a follow-up issue for this bug.
edit: This bug is already reported in #2987125: After updating from 7.x-2.3 to 7.x-2.4 Content Inclusion Options NOT Saving.

sjerdo’s picture

Status: Needs work » Needs review
sjerdo’s picture

sjerdo’s picture

joegraduate’s picture

Status: Needs review » Reviewed & tested by the community

Test changes look good to me. A new bug fix release is needed ASAP.

pifagor’s picture

  • pifagor committed c30e0f9 on 7.x-2.x authored by sjerdo
    Issue #2989571 by sjerdo, joegraduate, pifagor: Fix tests for 7.x-2.x-...
pifagor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.