Problem / motivation

  • Drupal 7 site has three languages enabled: EN (default), FI, SV
  • UI language detection has URL and Default enabled
  • Content language detection has URL, Interface and Default enabled
  • Upgrade to Drupal 8 using Migrate Drupal UI
  • Navigate to admin/config/regional/language/detection/url on your Drupal 8 site
  • Try to save the language detection configuration.
  • D8 does not allow saving the configuration and shows error message:
    The domain for English, example.com, is not unique.
    The domain for Finnish, example.com, is not unique.
    The domain for Swedish, example.com, is not unique.

Categorizing this as Critical since the upgrade results into corrupted data that the site builder can't fix in the UI.

CommentFileSizeAuthor
#5 2985716-5.patch2.83 KBmaxocub
#5 2985716-5-test-only.patch1.32 KBmaxocub
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

masipila created an issue. See original summary.

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented
Issue summary: View changes
masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented
Parent issue: » #2208401: [META] Remaining multilingual migration paths

Added to the parent meta.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented

You can fix this with the UI, if you switch to domain negotiation, you'll see the three same domains for your three languages. You can remove those domains and come back to prefix negotiation.

I'm working on a patch right now.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Active » Needs review
FileSize
2985716-5-test-only.patch1.32 KB
2985716-5.patch2.83 KB

This is due to the fact that the Language source plugin and the LanguageDomains process plugin use 'domain_negotiation' both as a source configuration and a source property. This was causing the 'domain_negotiation' property to be always TRUE if the 'domain_negotiation' configuration was TRUE. I changed the name of the property.

The last submitted patch, 5: 2985716-5-test-only.patch, failed testing. View results

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented

Whoa, that was fast @maxocub!

I'll test this when I get back home at the end of next week unless somebody else has already reviewed and tested this at that point of time.

Cheers,
Markus

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented
Status: Needs review » Reviewed & tested by the community

There is a fail test that demonstrates the issue and the patch passes the new test.

I tested this manually and patch 5 resolves the issue as expected.

This is ready in my opinion. RTBC.

Cheers,
Markus

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2985716-5.patch, failed testing. View results

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Test bot hiccups, back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 37e09ab49c to 8.7.x and 5adaf06176 to 8.6.x. Thanks!

  • alexpott committed 37e09ab on 8.7.x 
    Issue #2985716 by maxocub, masipila: Cannot save language negotiation...

  • alexpott committed 5adaf06 on 8.6.x 
    Issue #2985716 by maxocub, masipila: Cannot save language negotiation...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.7.x-dev » 8.6.x-dev