Problem/Motivation

No tests means applying patches feels like Russian roulette and it is hard to know stability for new or existing functionality.

Remaining tasks

Write initial simple tests.
Further tests should be written for most bug fixes and new features as relevant.

UI/API/Data model changes

No expected changes although some cleanup may be necessary.

CommentFileSizeAuthor
#7 2985211-test-suit-7.patch14.65 KBNickDickinsonWilde
#5 2985211-test-suit-5.patch14.15 KBNickDickinsonWilde
#3 2985211-test-suit-3.patch14.09 KBNickDickinsonWilde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NickWilde created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Related issues: +#2890042: Token support for Color CSS declaration

Noticed this wasn't fixed in creating tests for the css color formatter.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Active » Needs review
FileSize
2985211-test-suit-3.patch14.09 KB

An initial grouping of tests - checks all formatters and the basic color field item.

Status: Needs review » Needs work

The last submitted patch, 3: 2985211-test-suit-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs work » Needs review
FileSize
2985211-test-suit-5.patch14.15 KB

Lets see if that works.

Status: Needs review » Needs work

The last submitted patch, 5: 2985211-test-suit-5.patch, failed testing. View results

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs work » Needs review
FileSize
2985211-test-suit-7.patch14.65 KB

*something* about the schema it doesn't like.

Status: Needs review » Needs work

The last submitted patch, 7: 2985211-test-suit-7.patch, failed testing. View results

  • NickWilde committed f6955d5 on 8.x-2.x 
    Issue #2985211 by NickWilde: Create a test suit

  • NickWilde committed 9a96be4 on 8.x-2.x 
    Issue #2985211 by NickWilde: Create a test suit
Test improvements.
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs work » Fixed

Still on the 'light' side, but it exists so we'll call this done and add tests as required when bug or feature tickets happen.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.