After updating "Media" module to latest 7.x-2.x version this error became appear in Media modal window:

Notice: Undefined index: multiselect in template_preprocess_media_views_view_media_browser() (line 130 of sites/all/modules/contrib/media/media.views.inc).

CommentFileSizeAuthor
#10 media_undefined-index-multiselect_2985057-10.patch767 bytesjoseph.olstad
#8 media_undefined-index-multiselect_2985057-8.patch767 bytesjoseph.olstad
#4 media_undefined-index-multiselect_2985057-3.patch739 bytesharshil.maradiya
#2 media_undefined-index-multiselect_2985057-2.patch740 bytesdmytro-aragorn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dmytro-aragorn created an issue. See original summary.

dmytro-aragorn’s picture

dmytro-aragorn
Primary language Ukrainian
Location Lutsk
CreditAttribution: dmytro-aragorn at DevBranch commented
FileSize
media_undefined-index-multiselect_2985057-2.patch740 bytes

Here is a patch

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Active » Needs review

that code I believe is to support bulk upload using multiform and plupload.

alternatively you can enable the multiform module following the quick install guide.

however yes, lets look at this patch.
couple of suggestions:
rather than !empty() (negative is TRUE)
could use a positive is TRUE condition like isset()

Also, we could alternatively put a notice message in the watchdog about optionally installing plupload /multiform for bulk upload ability.

Thanks for the patch! lets trigger the tests.

harshil.maradiya’s picture

harshil.maradiya CreditAttribution: harshil.maradiya commented
FileSize
media_undefined-index-multiselect_2985057-3.patch739 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Reviewed & tested by the community

RTBC patch 3

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

actually, this patch should be
(isset($blah) && $blah)

to check for true.
I will reroll this.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs work » Needs review
FileSize
media_undefined-index-multiselect_2985057-8.patch767 bytes

new patch

ah ben tabarn#k

Status: Needs review » Needs work

The last submitted patch, 8: media_undefined-index-multiselect_2985057-8.patch, failed testing. View results

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
media_undefined-index-multiselect_2985057-10.patch767 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Title: Notice: Undefined index: multiselect in template_preprocess_media_views_view_media_browser() » Notice: Undefined index when media_bulk_upload, plupload and multiform are disabled : multiselect in template_preprocess_media_views_view_media_browser()

change title

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Title: Notice: Undefined index when media_bulk_upload, plupload and multiform are disabled : multiselect in template_preprocess_media_views_view_media_browser() » If media_bulk_upload, plupload and multiform are disabled: watchdog Notice: Undefined index multiselect in template_preprocess_media_views_view_media_browser()
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed

Thx

  • joseph.olstad committed 282dbe3 on 7.x-4.x 
    Issue #2985057 by joseph.olstad, dmytro-aragorn, harshil.maradiya: If...

  • joseph.olstad committed be11dd6 on 7.x-3.x 
    Issue #2985057 by joseph.olstad, dmytro-aragorn, harshil.maradiya: If...

  • joseph.olstad committed 815c76c on 7.x-2.x 
    Issue #2985057 by joseph.olstad, dmytro-aragorn, harshil.maradiya: If...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.