Hi there,

I got the follow error message on the php7.1 versions.

Warning: Parameter 1 to protected_node_protected_node_hide() expected to be a reference, value given in protected_node_invoke()

I think maybe we should change the the function from call_user_func to call_user_func_array

Does anybody face the same problems?

CommentFileSizeAuthor
#10 2018-11-22 at 8.16 AM.png104.51 KBcobenash
#8 fix-1-parameter-2985028-1.patch447 bytescobenash
#4 fix-1-parameter-2985028-1.patch447 bytescobenash
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cobenash created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Active » Postponed (maintainer needs more info)

Hello,

Thanks for reporting a bug.

Please provide steps to reproduce or even better a patch with a failing automated test.

lmonk’s picture

lmonk CreditAttribution: lmonk commented

Having the same issue with 7.x-1.4

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
FileSize
fix-1-parameter-2985028-1.patch447 bytes
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Postponed (maintainer needs more info) » Needs review

Hello,

@cobenash, thanks to have provided a patch.

When providing a patch, the issue status should be changed to "needs review" to trigger Drupal.org CI.

Also can you please provide steps to reproduce/test your patch?

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Needs review » Postponed (maintainer needs more info)

As the comment that has posted the patch is not the same as the one changing the issue status, Drupal.org CI will not be triggered.

So moving back to "maintainer needs info" while not having steps to reproduce.

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
Status: Postponed (maintainer needs more info) » Needs review
cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
FileSize
fix-1-parameter-2985028-1.patch447 bytes

@Grimreaper Sorry for late response. I reproduce/test on this patch .

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Needs review » Postponed (maintainer needs more info)

Hi,

@cobenash, again the comment having the patch is not the same as the one that changes the status to needs review.

And also, I need steps to reproduce the bug starting from a fresh Drupal install.

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
FileSize
2018-11-22 at 8.16 AM.png104.51 KB

@Credit,

The error message will occur when anonymous visit the article list with teaser view.

show error message

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Postponed (maintainer needs more info) » Needs review

The error was showing for me, and patch #8 resolved it. Thanks!

  • Grimreaper committed 0773d78 on 7.x-1.x authored by cobenash 
    Issue #2985028 by cobenash, Grimreaper, DamienMcKenna: Warning:...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Needs review » Fixed

Hello,

Thanks for the screenshot.

I have been able to reproduce the warning and the patch fixes it.

Merged.

I will make a new release soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.