Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
While adding a test to the Migration plugin (#2959097: Log message if migration plugin skip the row When there is no destination found. ) it was noticed that there is no test for whether Migration::getProcessPlugins() throws an exception when it should.
Proposed resolution
Add missing test.
Remaining tasks
Write test.
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#4 | 2984610-4.patch | 1.08 KB | jofitz |
#4 | interdiff-2984610-2-4.txt | 796 bytes | jofitz |
#2 | 2984610-2.patch | 1.1 KB | jofitz |
Comments
Comment #2
jofitz CreditAttribution: jofitz at ComputerMinds commentedWrote test.
Comment #3
quietone CreditAttribution: quietone as a volunteer commentedHey, great find. Just one small thing.
The assertion can be removed, just need the call to getProcessPlugins.
Comment #4
jofitz CreditAttribution: jofitz at ComputerMinds commentedSimplified the test as suggested.
Comment #5
quietone CreditAttribution: quietone as a volunteer commentedAgain, good find and thanks for cleaning it up.
Previously, I applied the patch and tested manually. The last change still passes tests, so this ready to go.
Comment #7
alexpottCommitted and pushed bbac45a7ba to 8.7.x and bbf232ce97 to 8.6.x. Thanks!