Problem/Motivation

While adding a test to the Migration plugin (#2959097: Log message if migration plugin skip the row When there is no destination found. ) it was noticed that there is no test for whether Migration::getProcessPlugins() throws an exception when it should.

Proposed resolution

Add missing test.

Remaining tasks

Write test.

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jo Fitzgerald created an issue. See original summary.

jofitz’s picture

Assigned: jofitz » Unassigned
Status: Active » Needs review
Issue tags: -Needs tests
FileSize
1.1 KB

Wrote test.

quietone’s picture

Status: Needs review » Needs work

Hey, great find. Just one small thing.

+++ b/core/modules/migrate/tests/src/Kernel/Plugin/MigrationTest.php
@@ -28,6 +29,17 @@ public function testGetProcessPlugins() {
+    $this->assertEquals([], $migration->getProcessPlugins(['foobar' => ['plugin' => 'get']]));

The assertion can be removed, just need the call to getProcessPlugins.

jofitz’s picture

Status: Needs work » Needs review
FileSize
796 bytes
1.08 KB

Simplified the test as suggested.

quietone’s picture

Status: Needs review » Reviewed & tested by the community

Again, good find and thanks for cleaning it up.

Previously, I applied the patch and tested manually. The last change still passes tests, so this ready to go.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed bbac45a7ba to 8.7.x and bbf232ce97 to 8.6.x. Thanks!

  • alexpott committed bbac45a on 8.7.x
    Issue #2984610 by Jo Fitzgerald, quietone: Migration::getProcessPlugins...

  • alexpott committed bbf232c on 8.6.x
    Issue #2984610 by Jo Fitzgerald, quietone: Migration::getProcessPlugins...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.