There is an option "Number of uses per coupon" at coupon generation form.
If I select "Unlimited" it always generated coupons with the limit for 1 usage.

How to reproduce:

  1. Open the generation form
  2. Select the unlimited option
  3. Click the generate button
  4. Check the results

There is the hack right now, how to generate unlimited coupons:

  1. Open the generation form
  2. Enter the "0" into textfield for limit number
  3. Select the unlimited option
  4. Click the generate button
  5. Check the results ;)
CommentFileSizeAuthor
#4 commerce-2981460-unlimited_generation-3.patch2.16 KBczigor
#4 commerce-2981460-unlimited_generation-3_ONLY_TEST.patch1.49 KBczigor
#2 unlimited_generation-2981460-2.patch676 byteskala4ek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kala4ek created an issue. See original summary.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented
Status: Active » Needs review
FileSize
unlimited_generation-2981460-2.patch676 bytes

Here is a simple patch, that fixes that.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Needs work
Issue tags: +Needs tests

We definitely need tests, then

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
Status: Needs work » Needs review
FileSize
commerce-2981460-unlimited_generation-3_ONLY_TEST.patch1.49 KB
commerce-2981460-unlimited_generation-3.patch2.16 KB

The last submitted patch, 4: commerce-2981460-unlimited_generation-3_ONLY_TEST.patch, failed testing. View results

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work

Previously the test confirmed that it was possible to limit usage.
Now the test confirms only that it is possible to not limit usage.
We need both.

  • bojanz committed b3f0a17 on 8.x-2.x 
    Issue #2981460 by czigor, kala4ek, bojanz: "Unlimited" generation option...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed
Issue tags: -Needs tests

Rewrote the test and committed. Thanks, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.