Platform verification failed if we use Git repo

Good catch. Some review:

+++ b/drush/provision_git.drush.inc
@@ -455,7 +455,13 @@ function _provision_git_update_git_meta_data() {
-      $git_ref = trim(str_replace('refs/heads/', '',drush_shell_exec_output()));;
+      $temp_git_ref =  str_replace('refs/heads/', '',drush_shell_exec_output());
+      ¶
+      if(!empty($temp_git_ref) && is_string($temp_git_ref)) {
+        $temp_git_ref = trim($temp_git_ref);
+      }
+
+      $git_ref = $temp_git_ref;

All of this could be shortened to:

$temp_git_ref = str_replace('refs/heads/', '',drush_shell_exec_output());
$git_ref = (!empty($temp_git_ref) && is_string($temp_git_ref)) ? trim($temp_git_ref) : $temp_git_ref;

Other minor things:

• Extra whitespace on line 460.
• Space needed after "if", but we no longer need it.

Code looks good. It would be great if someone else could test it, but maybe we're okay with the tests we have.

I noticed the same warning and this patch resolved it.

Committed.