Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In Umami theme login link not showing underline on hover. All other links are underlined on hover e.g: the main menu, footer links are underlined on hover.
Comment | File | Size | Author |
---|---|---|---|
#9 | 03-with-patch-applied-hovered.png | 7.93 KB | markconroy |
#9 | 02-current-hovered.png | 7.83 KB | markconroy |
#9 | 01-default-state.png | 7.2 KB | markconroy |
#7 | 2971546-7.patch | 579 bytes | Mukeysh |
#2 | after-applying-patch.png | 960.69 KB | Mukeysh |
Comments
Comment #2
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedApplying the patch for the above. Please review. Attaching screenshot for reference.
Comment #3
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedComment #4
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedComment #5
msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commentedUsing
border-bottom
for the underline effect to an anchor tag is not a correct way to do it.text-decoration: underline;
is more better way to do it.Umami theme already has these lines of code in
menu-account.css
which you are overriding. Looks like it is intentional to not show underline on hover on login link. Need input from core committer or umami theme maintainer whether we want to show hover effect on login link or not.
Comment #6
markconroy CreditAttribution: markconroy at Annertech commentedHi Folks,
Thanks for working on this.
I think we do need something to differentiate hover from normal state, and I think underline is the safest. We have links in the main body underlined when in normal state and not underlined when hovered, so I'd prefer an underline approach rather than a border-bottom one.
If someone can get a patch for that, I'll get it tested.
Comment #7
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedI have added patch with
text-decoration: underline;
on hover. Please review.Comment #8
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedComment #9
markconroy CreditAttribution: markconroy as a volunteer and at Annertech commentedThanks @Mukeysh,
Marking this as RTBC.
Just for future reference, we like to provide before/after screenshots for frontend changes, since we don't have automatic regression tools built in for our themes. I'll provide them here.
Current default state:
Current state, when hovered:
Hovered state, after patch applied:
Committers, can we also credit @msankhala on this issue please.
Comment #10
alexpottCommitted and pushed d48980d4c3 to 8.6.x and cd3d2bf6df to 8.5.x. Thanks!