Problem/Motivation

BTB tests are currently failing on 8.x-1.x, have been for a long while.

Proposed resolution

Fix 'em.

Remaining tasks

Code, test.

User interface changes

NA

API changes

NA

Data model changes

NA

CommentFileSizeAuthor
#4 2967988-3.patch8.4 KBfenstrat
#2 2967988-2.patch16.81 KBfenstrat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fenstrat created an issue. See original summary.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
FileSize
2967988-2.patch16.81 KB

Attached:

  1. Fixes PHPCS.
  2. 'Save and publish' is now just 'Save'.
  3. Switches do while to foreach/for.
  4. Updates config export for block_field_widget_test module.
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
Status: Active » Needs review
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
FileSize
2967988-3.patch8.4 KB

Updated patch to properly handle the rename.

Status: Needs review » Needs work

The last submitted patch, 4: 2967988-3.patch, failed testing. View results

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
Status: Needs work » Reviewed & tested by the community

BTB are passing so going to commit, up next will be converting the WTB test to BTB (and fixing it).

  • fenstrat committed 91d7330 on 8.x-1.x 
    Issue #2967988 by fenstrat: Fix failing BTB tests
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.