This link appears when comments are enabled but not available to anonymous users - we need a test to ensure it appears correctly.

CommentFileSizeAuthor
#7 comment-register-296484.patch1.11 KBjonskulski
#4 issue-296484.patch1.06 KBlilou
#2 anon_user.patch845 bytesswentel
#1 anon_user.patch718 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
anon_user.patch718 bytes
swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
anon_user.patch845 bytes

Changed hardcoded nid, looks better.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Patch applies with offset, runs fine, test looks good. RTBC.

lilou’s picture

lilou CreditAttribution: lilou commented
FileSize
issue-296484.patch1.06 KB

Re-roll.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

Unfortunately this test fails for me. :( Can someone take a look?

swentel’s picture

swentel CreditAttribution: swentel commented

weird, no problem here .. not sure what goes wrong

jonskulski’s picture

jonskulski CreditAttribution: jonskulski commented
Status: Needs work » Needs review
FileSize
comment-register-296484.patch1.11 KB

@webchick: are you running out of a ~/public_html/ or similar?

Original patch assertedRaw which looked for href="/user/login...", but if you're using a RewriteBase then your urls will look something like href="/~jskulski/drupal7/user/login" and will fail the test.

This might explain what was happening, because the test was failing for me until I changed the urls to reflect my rewrite base.

Here is a rewrite of the patch that gets the links from the url function. I didn't see many examples of assertRaw with links, but this might be something to watch out for in the future.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

The last submitted patch failed testing.

emad964’s picture

emad964 CreditAttribution: emad964 commented
Component: tests » base system

There's no problem here

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Category: bug » task
Priority: Critical » Normal

Moving out of the critical bug queue, see #607038: Meta issue: fix gaps in code coverage

bhavesh_gloscon’s picture

bhavesh_gloscon CreditAttribution: bhavesh_gloscon commented

same problem when updating website Drupal 7 alpha to Drupal 7.0

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

F*cking spammers.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

...