Hey,

I think it would be neat if we could use this module in combination with Drupal core's file_public_base_url setting. The attached patch should make that possible.

Is there any downside to this change? I'll be happy to work on implementing any changes appropriate or necessary.

Thanks!

CommentFileSizeAuthor
drupal-flysystem-s3-file-public-base-url-support.patch985 bytesjan.stoeckler

Comments

jan.stoeckler created an issue. See original summary.

misc’s picture

misc commented
Status: Needs review » Postponed (maintainer needs more info)

I don't really think this make sense - we have settings for the URL in the settings, plus you could use a prefix in the settings.

$schemes = [
    's3' => [
        'driver' => 's3',
        'config' => [
            'key'    => 'key',      // 'key' and 'secret' do not need to be
            'secret' => 'secret',   // provided if using IAM roles.
            'region' => 'us-east-1',
            'bucket' => 'foo',
            'endpoint' => "http://minio:9000",
            'protocol' => "http",
            'cname_is_bucket' => false,
            "cname" => "minio.mydomain:8000",
            'use_path_style_endpoint' => TRUE,
            'public' => true,
            'prefix' => 'bar',
        ],
    ],
];
$settings['flysystem'] = $schemes;