Remove PHP5.5 performance optimisations in Container::createService and PhpArrayContainer::createService

5.5. support is now dropped.

if ($length <= 10) {
  $service = new $class(...$arguments);
}
else {
  $r = new \ReflectionClass($class);
  $service = $r->newInstanceArgs($arguments);
}

If we can now use $arguments, then we can use it for more than 10 arguments and drop the whole reflection class thing?

So the code becomes

    else {
      $class = $this->frozen ? $definition['class'] : current($this->resolveServicesAndParameters([$definition['class']]));
      $service = new $class(...$arguments);
    }

Thank @govind.maloo!

The test fail is a random (#3103492: Random fail in WidgetUploadTest, so we can ignore that.

However, we need to patch the same problem in Container.php as well as PhpArrayContainer.php. Resetting to Needs Work for that.

This is an awesome and clean solution to use "Variable-length argument lists"

Crediting @msankhala for filing the issue. @jonathanshaw for coming up with the solution.

Committed and pushed 79938c6da5 to 9.0.x and b040e57c1b to 8.9.x. Thanks!