Upstream ticket is #2925449: [PHP 7] Function each() is deprecated since PHP 7.2 [D7], which is RTBC. Can we add the patch to the makefile?

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Related issues: +#2925449: [PHP 7] Function each() is deprecated since PHP 7.2 [D7]
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

#2925449-80: [PHP 7] Function each() is deprecated since PHP 7.2 [D7] seems to work well.

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented
Status: Active » Needs review

probably...

We should then also pin to 7.58 to avoid failing when the next release comes out.

projects[drupal][version] = 7.58
projects[drupal][patch][] = "https://www.drupal.org/files/issues/2018-04-08/deprecated_each2925449-106.patch"
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Reviewed & tested by the community

Right. We can remove all of this stuff when it gets committed upstream.

  • helmo committed 92b7c9d on 7.x-3.x 
    Issue #2962836 by colan, helmo: The each() function is deprecated in PHP...
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented
Status: Reviewed & tested by the community » Fixed

Committed.

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented
Status: Fixed » Needs review

:(

Packaging error messages

Build for drupal-org.make failed:

projects[drupal] is not allowed in a regular drupal-org.make file. Use the 'core' attribute to specify a stable release of Drupal core. For -dev releases and patches, use a drupal-org-core.make file.
The Drupal.org validation check failed -- see https://www.drupal.org/node/1432190 for more information.

Going for 3.15.1

  • helmo committed 7b1d365 on 7.x-3.x 
    Issue #2962836: Fixup makefile
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented
Status: Needs review » Fixed

Colan, please create a new issue for the other core patch you found ...
Note that we need to update a makefile in both provision and hostmaster.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.