Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.INSTALL.txt file in core directory consists installation commands with respect to root directory. For eg-
These command is also wrt to root directory.
chmod go-w sites/default/settings.php
chmod go-w sites/default/settings.php
chmod go-w sites/default
but in point 6 under installation, CHANGELOG.txt file is in core directory so its command should be
chmod a-r core/CHANGELOG.txt
rather than
chmod a-r CHANGELOG.txt
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fix-path-2962508-3patch.png | 130.41 KB | amietpatial |
| #3 | fix-path-2962508-3.patch | 488 bytes | ankitjain28may |
Comments
Comment #2
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and commentedComment #3
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and commentedFixed, pls review.
Comment #4
amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented@ankitjain28may your patch applied successfully and it works fine
Comment #5
borisson_@amietpatial uploading screenshots like that isn't helpful, we can see from the testbot that the patch applies. The patch does look solid.
Comment #6
alexpottBackported to 8.5.x as a docs fix.
Committed and pushed 7e4118627f to 8.6.x and 1488a6ccc3 to 8.5.x. Thanks!
@amietpatial Posting screenshots of your codebase is not helpful, since the automated testing infrastructure tells us whether the patch applies correctly. So, I've removed your credit for this issue. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose.
What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.
When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).
Comment #9
amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented@alexpott and borisson_ Thanks for the review and feedback much appreciated will take care in future.