A new article providing tips for common baking mishaps for the Umami Demo. Creating this issue to get the article reviewed and added into the articles section of Umami. Please see text version attached.

Here's the suggested CSV content. I will work on an image this week:

Baking mishaps - our troubleshooting tips,
baking-mishaps-our-troubleshooting-tips.html,
"Umami",
articles/baking-mishaps-our-troubleshooting-tips,
image-to-be-supplied.jpg,
"Alt text to be supplied",
"Baking,Learn to cook"

Todo:

  • Article still needs official non-placeholder photo.
  • Write alt text for said image.
  • Decide on cookie vs. biscuit
CommentFileSizeAuthor
#12 interdiff-2960711-8-12.txt3.19 KByogeshmpawar
#12 2960711-12.patch4.16 KByogeshmpawar
#8 2960711-umami-baking-mishaps-article-8.patch4.21 KBtimwood
#4 2960711-umami-baking-mishaps-article.patch4.22 KBtimwood
baking-mishaps-our-troubleshooting-tips.txt2.34 KBkjay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kjay created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina as a volunteer commented
Issue tags: +Nashville2018, +Novice
timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
Assigned: Unassigned » timwood

I'm working on this at the DrupalCon Nashville sprints!

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
FileSize
2960711-umami-baking-mishaps-article.patch4.22 KB

One minor comment on the content:

In the "Your cookies burned" section, it refers to cookies as "bottom of your biscuits". Should biscuits be "cookies", or was biscuits just used as a different term to refer to a cookie?

Initial patch attached. I reused the vegan brownie image, for now. This and the alt text will need updating.

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
Issue summary: View changes
timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
Assigned: timwood » Unassigned
timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
Issue summary: View changes

FYI, I did NOT make the biscuits/cookie wording change in my patch, or the original article txt file.

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
CreditAttribution: timwood as a volunteer commented
FileSize
2960711-umami-baking-mishaps-article-8.patch4.21 KB

Second patch, without funny ’ characters.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina as a volunteer commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work

Both files don't have a newline at the end of the file, and they should have.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
2960711-12.patch4.16 KB
interdiff-2960711-8-12.txt3.19 KB

Added newline in both files within updated patch & also added an interdiff.

brucedarby’s picture

brucedarby CreditAttribution: brucedarby at The University of Edinburgh commented

Picking this up at DrupalCamp Scotland.

brucedarby’s picture

brucedarby CreditAttribution: brucedarby at The University of Edinburgh commented

Installed the patch and all looks perfect.

brucedarby’s picture

brucedarby CreditAttribution: brucedarby at The University of Edinburgh commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 2960711-12.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Needs work » Reviewed & tested by the community

Testbot Snafu.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9ed571d529 to 8.6.x and e224a9b26a to 8.5.x. Thanks!

  • alexpott committed 9ed571d on 8.6.x 
    Issue #2960711 by timwood, Yogesh Pawar, kjay: Add an article to Umami...

  • alexpott committed e224a9b on 8.5.x 
    Issue #2960711 by timwood, Yogesh Pawar, kjay: Add an article to Umami...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.