Problem/Motivation

If you install Drupal with the Umami profile and go to the Recipes page, the hover state for the call-to-action button on the hero image doesn't have the border radius existing on the default state.

Proposed resolution

Add the existing border radius to the hover state.

CommentFileSizeAuthor
#8 umami.gif139.56 KBSaintNexcis
#7 new-hover.png112.86 KBkaythay
#7 2960528.patch648 byteskaythay
hover.png969.21 KBckrina
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Ymbra commented
Title: Fix styles for radius on hover » Fix styles for radius on hover for Recipies banner in Umami
Issue summary: View changes

Fix title and credit

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina as a volunteer commented
Title: Fix styles for radius on hover for Recipies banner in Umami » Fix styles for border radius on hover state for Recipies banner in Umami
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher at Isovera commented
Issue tags: +Nashville2018, +Novice
SaintNexcis’s picture

SaintNexcis CreditAttribution: SaintNexcis as a volunteer commented

I'm taking a look at this while here at DrupalCon Nashville Novice Sprint.

SaintNexcis’s picture

SaintNexcis CreditAttribution: SaintNexcis as a volunteer commented

I'm unable to replicate the issues described. I'm sitting at the Umami table in the mentoring room at DrupalCon Nashville2018.

kaythay’s picture

kaythay CreditAttribution: kaythay commented
Status: Active » Needs review
FileSize
2960528.patch648 bytes
new-hover.png112.86 KB

Here's a patch removing outline to add box-shadow.

SaintNexcis’s picture

SaintNexcis CreditAttribution: SaintNexcis as a volunteer commented
Status: Needs review » Active
FileSize
umami.gif139.56 KB

Figured out (Thanks to Kaythay) that I was running D8.5 and not D8.6.....

Tested her patch, works great.

hover

kaythay’s picture

kaythay CreditAttribution: kaythay commented
Status: Active » Needs review

Moving this back to Needs Review.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community

I have verified this patch. This patch applies well. Steps I followed:

  1. Install fresh drupal 8.6.x with Umami Demo profile.
  2. Go to home page and verify that call to action button on hero banner is having a border with no radios on hover.
  3. Download and apply the patch #7.
  4. Clear cache and visit homepage again. Now in hover state this button has border radius same as without hover.
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher at Isovera commented

Nice screenshot, @SaintNexcis!

  • lauriii committed ad52056 on 8.6.x 
    Issue #2960528 by kaythay, ckrina, SaintNexcis, benjifisher, msankhala:...

  • lauriii committed 3ce0f1b on 8.5.x 
    Issue #2960528 by kaythay, ckrina, SaintNexcis, benjifisher, msankhala:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thank you everyone! This caught my eye while testing Umami so it is great to see this getting fixed 👍

Committed ad52056 and pushed to 8.6.x. Also cherry-picked 3ce0f1b and pushed to 8.5.x Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.