Problem/Motivation

We are rendering facets from different sources (where some facets are duplicated). Currently it is not possible to have different results for this duplicate facets since processFacets() does not take the source ID into account.

Proposed resolution

Make $this->processedFacets aware of the facets source ID.

Remaining tasks

* Create patch

CommentFileSizeAuthor
#2 facets-processFacets_sourceID-2960088-2.patch994 bytesstBorchert
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stBorchert created an issue. See original summary.

stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert at undpaul commented
Issue summary: View changes
Status: Active » Needs review
FileSize
facets-processFacets_sourceID-2960088-2.patch994 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

This shouldn't be a problem, the facet ID is always unique - or at least it should be.

SteffenR’s picture

SteffenR
Primary language English
Location Bremen
CreditAttribution: SteffenR at undpaul commented
Status: Needs review » Reviewed & tested by the community

I also had this problem in a project and the patch resolved the issue for me.
Looks fine for me and we should take the status to RTBC if anyone is fine with it?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

As a happy side-effect, this is making things a little bit faster. On my local machine, on a view with

With patch:

Requests per second:    1.17 [#/sec] (mean)
Time per request:       858.088 [ms] (mean)

Without patch:

Requests per second:    1.09 [#/sec] (mean)
Time per request:       920.085 [ms] (mean)

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.