I have observed that when we export menu items in which icons are set, the generated yml file does not include these references.

I'm using the icons module (https://www.drupal.org/project/icons) + MD Fontello (https://www.drupal.org/project/md_fontello) to set icons.

I have developed a solution but of course I would like your opinion.

Thanks

CommentFileSizeAuthor
#4 structure_sync.data_.yml416 bytesdaniel.delaiglesia
#4 screenshot.png34.85 KBdaniel.delaiglesia
#2 2959845-support-for-icons-in-menu-items.patch2.61 KBdaniel.delaiglesia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daniel.delaiglesia created an issue. See original summary.

daniel.delaiglesia’s picture

daniel.delaiglesia CreditAttribution: daniel.delaiglesia as a volunteer commented
FileSize
2959845-support-for-icons-in-menu-items.patch2.61 KB

My proposed solution.

I have also tried enabling the Menu Link Atributtes module (https://www.drupal.org/project/menu_link_attributes) and it works by setting attributes and icons.I would be delighted if you could review the proposed solution.

Thank you very much

timKruijsen’s picture

timKruijsen CreditAttribution: timKruijsen at Ordina Digital Services commented

Your patch seems to remove support for attributes, is that done deliberately?

daniel.delaiglesia’s picture

daniel.delaiglesia CreditAttribution: daniel.delaiglesia as a volunteer commented
FileSize
screenshot.png34.85 KB
structure_sync.data_.yml416 bytes

I think that it is not necessary to establish them since they are established in the options of the menu item. That is why I replace it.
This yml structure works correctly for me when I import the code again...it is why I wanted your wise opinion

I attached a screenshot of an item and the yml code it generates.

Thanks

timKruijsen’s picture

timKruijsen CreditAttribution: timKruijsen at Ordina Digital Services commented
Status: Active » Fixed

Then it looks good to me! Released in 8.x-1.12. Thank you for your contribution.

daniel.delaiglesia’s picture

daniel.delaiglesia CreditAttribution: daniel.delaiglesia as a volunteer commented

Thank you very much for your prompt reply!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.