Problem/Motivation

Are skipping the deprecation The Twig_Node::getLine method is deprecated since version 1.27 and will be removed in 2.0. Use getTemplateLine() instead.

Proposed resolution

Remove that line and fix the code

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2959276-2.patch1.36 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Active » Needs review
FileSize
2959276-2.patch1.36 KB

Let's see what breaks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

This was fixed in #2884675: Remove twig uses of Twig_Node::getLine to Twig_Node::getTemplateLine - but the skipped deprecation was not removed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Lets remove it then.

  • lauriii committed 2302f59 on 8.6.x 
    Issue #2959276 by alexpott: Twig_Node::getLine() is deprecated
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Double checked that there's no usages left and I can confirm that all the usages of Twig_Node::getLine() has been removed. Committed 2302f59 and pushed to 8.6.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.