Missing hook_help text in user_expire.module file.

CommentFileSizeAuthor
#11 af1.png48.1 KBriddhi.addweb
#11 aph.png101.54 KBriddhi.addweb
#11 bph.png46.49 KBriddhi.addweb
#9 update_user_expire-2957776-9.png27.23 KBamit.drupal
#9 interdiff.txt800 bytesamit.drupal
#9 2957776-9.patch1.21 KBamit.drupal
#8 user_expire-help.png58.23 KBamit.drupal
#6 2957776-2.patch1.2 KBlomasr
#5 BEFORE PATCH.png111.03 KBriddhi.addweb
#5 AFTER PATCH.png51.81 KBriddhi.addweb
#2 2957776.patch884 byteslomasr

Comments

lomasr created an issue. See original summary.

lomasr’s picture

lomasr commented
StatusFileSize
new 2957776.patch884 bytes

Adding a patch. Please review

lomasr’s picture

lomasr commented
Status: Active » Needs review
riddhi.addweb’s picture

riddhi.addweb commented

@lomasr, Thanks for the patch for adding link & Creating the Help page. Still, As per the standards, you can modify this page & also add some more description into it.
You can use: https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new AFTER PATCH.png51.81 KB
new BEFORE PATCH.png111.03 KB
lomasr’s picture

lomasr commented
StatusFileSize
new 2957776-2.patch1.2 KB

patch added

lomasr’s picture

lomasr commented
Status: Needs work » Needs review
amit.drupal’s picture

amit.drupal commented
StatusFileSize
new user_expire-help.png58.23 KB

After apply patch found some issues, No space in link and text and double dots in the link.

amit.drupal’s picture

amit.drupal commented
StatusFileSize
new 2957776-9.patch1.21 KB
new interdiff.txt800 bytes
new update_user_expire-2957776-9.png27.23 KB

@lomasr

Update patch #6.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community

@amit.drupal, Thanks for the patch correction, it is working fine. I checked it using simplytest.me & attached the screenshot for the same.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new bph.png46.49 KB
new aph.png101.54 KB
new af1.png48.1 KB

  • shelane committed c18c20d on 8.x-1.x authored by lomasr 
    Issue #2957776 by lomasr, amit.drupal, riddhi.addweb: Missing hook_help...
shelane’s picture

shelane
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.