Mentioned in #2939871: Facet rest views broken

Create an option in the facets rest export to only show the original results, not the facets output as well.
Also test with csv export.

CommentFileSizeAuthor
#9 2956898.patch9.87 KBborisson_
#7 interdiff-2956898.txt991 bytesborisson_
#7 2956898.patch9.96 KBborisson_
#5 2956898.patch9.79 KBborisson_
#5 interdiff-2956898.txt9.42 KBborisson_
#2 2956898.patch4.8 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Active » Needs review
FileSize
2956898.patch4.8 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2956898.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

Looks like some other rest tests have begun failing since the last time the tests have ran on the testbot?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2956898.txt9.42 KB
2956898.patch9.79 KB

Looks like there is a problem with the url generation, I fixed it so that we now have passing rest tests.

Status: Needs review » Needs work

The last submitted patch, 5: 2956898.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs work » Needs review
FileSize
2956898.patch9.96 KB
interdiff-2956898.txt991 bytes
drasgardian’s picture

drasgardian CreditAttribution: drasgardian at Eighty Options commented
Status: Needs review » Reviewed & tested by the community

Thanks @borisson_, this is working well for me. Setting to RTBC

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
FileSize
2956898.patch9.87 KB

Rebased patch.

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
CreditAttribution: andreasderijcke at Calibrate commented

Tested, all good.

  • borisson_ committed 19d70a8 on 8.x-1.x 
    Issue #2956898 by borisson_: Add an option to the rest export to not...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.