As discussed in #2748307: Aspect Switcher, increase granularity of the ratio adjustment to 2nd decimal digit.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Status: Active » Needs review
FileSize
1.01 KB

Patch

lukedekker’s picture

Status: Needs review » Reviewed & tested by the community

Oh awesome, I was just about to create this myself. Thanks for providing the patch @mondrake.

Works perfectly for me.

mondrake’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

I think we can tweak a bit the AspectSwitcherTest and check that the ImageStyle config entity stores the adj ratio with double decimal digits.

mondrake’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
1.4 KB
2.41 KB

Added a test.

The last submitted patch, 5: 2956733-5-test-only.patch, failed testing. View results

mondrake’s picture

  • mondrake authored f2e84a1 on 8.x-2.x
    Issue #2956733 by mondrake, lukedekker: Aspect Switcher: Increase...

  • mondrake authored ae51210 on 8.x-1.x
    Issue #2956733 by mondrake, lukedekker: Aspect Switcher: Increase...
mondrake’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.