At core/modules/taxonomy/src/VocabularyForm.php, "Terms language" should be "Term's language". Edit: "Term language" would be consistent with "Vocabulary language" on the same form.

issue

CommentFileSizeAuthor
#13 terms-language-2956067-13.patch652 bytesnkoporec
#11 2956067-11.patch652 bytesbhanuprakashnani
#6 terms-language-2956067-6.patch654 bytesneeraprajapati
#3 terms-language-2956067-3.patch655 bytesneeraprajapati
add_vocabulary_terms_language.png17.18 KBkari.kaariainen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kari.kaariainen created an issue. See original summary.

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
Assigned: Unassigned » neeraprajapati

I am working on that, will update it soon.

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
Assigned: neeraprajapati » Unassigned
Status: Active » Needs review
FileSize
terms-language-2956067-3.patch655 bytes

Patch applied.

swels’s picture

swels CreditAttribution: swels as a volunteer commented
Status: Needs review » Needs work

after analyzing the core code via regex,
it seems that its more common to use wrapping double quotes - instead to escaping single quotes
e.g.
->t("The Drupal term IDs of the term's parents.")

kari.kaariainen’s picture

kari.kaariainen CreditAttribution: kari.kaariainen commented

True. According to coding standards, in this case it should be
->t("Term's language")

https://www.drupal.org/docs/develop/standards/coding-standards#quotes

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
FileSize
terms-language-2956067-6.patch654 bytes

Thanks for sharing coding standards link, I have applied a new patch.

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
Status: Needs work » Needs review
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented

Hi, tested the patch and I think it looks good.Great job!

kari.kaariainen’s picture

kari.kaariainen CreditAttribution: kari.kaariainen commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +String change in 8.6.0 
+++ b/core/modules/taxonomy/src/VocabularyForm.php
@@ -89,7 +89,7 @@ public function form(array $form, FormStateInterface $form_state) {
-        '#title' => $this->t('Terms language'),
+        '#title' => $this->t("Term's language"),

Yep this is wrong but I think Term language would be more consistent. We have Vocabulary language just above. I don't think the possessive is necessary.

bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
Status: Needs work » Needs review
FileSize
2956067-11.patch652 bytes

If it should be Term language, I have made the change and uploaded the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

@bhanuprakashnani can be single quotes again now.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented
FileSize
terms-language-2956067-13.patch652 bytes

Created a new patch with single quotes.

kari.kaariainen’s picture

kari.kaariainen CreditAttribution: kari.kaariainen commented
Title: "Terms language" should be "Term's language" » "Terms language" should be "Term's language" or "Term language"
Issue summary: View changes
mcgovernm’s picture

mcgovernm CreditAttribution: mcgovernm as a volunteer commented
Status: Needs review » Reviewed & tested by the community
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented
Title: "Terms language" should be "Term's language" or "Term language" » Change "Terms language" label to "Term language" in the Vocabulary default form

Saving credits

  • plach committed 3e1d6c2 on 8.6.x 
    Issue #2956067 by neeraprajapati, nkoporec, bhanuprakashnani, kari....
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.