Provide a Twig template and theme hook suggestions for checkout panes [#2951353]

From #2915585: Create a Twig template for the payment gateway form.

Right now we have no way to theme checkout panes. There should be "commerce_checkout_pane", "commerce_checkout_pane_PLUGIN_ID" theme hook and then Payment alters it to have the additional suggestions on operation and plugin ID.

Comment	File	Size	Author
#3	2951353-3.patch	2.21 KB	mglaman
#3	8.x-2.x: PHP 5.5 & MySQL 5.5, D8.5 454 pass
#2	2951353-2.patch	2.02 KB	mglaman
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 March 2018 at 22:23

mglaman created an issue. See original summary.

Comment #2

mglaman

English

WI, USA

CreditAttribution: mglaman commented 8 March 2018 at 22:35

Assigned:	Unassigned	» mglaman
Status:	Active	» Needs work

File	Size
2951353-2.patch	2.02 KB

This causes panes to have no output. Need preprocess to fix "content." Ending sprint for the day.

Comment #3

mglaman

English

WI, USA

CreditAttribution: mglaman commented 8 March 2018 at 23:34

Assigned:	mglaman	» Unassigned
Status:	Needs work	» Needs review

File	Size
2951353-3.patch	2.21 KB
8.x-2.x: PHP 5.5 & MySQL 5.5, D8.5 454 pass

Today I, shamefully, learned "render element" defines the main variable for all renderables!

Theme debug output from patch

<!-- THEME DEBUG -->
<!-- THEME HOOK: 'commerce_checkout_pane' -->
<!-- FILE NAME SUGGESTIONS:
   * commerce-checkout-pane--shipping-information.html.twig
   x commerce-checkout-pane.html.twig
-->
<!-- BEGIN OUTPUT from 'modules/contrib/commerce/modules/checkout/templates/commerce-checkout-pane.html.twig' -->

Comment #4

28 March 2018 at 12:30

bojanz committed 522e74c on 8.x-2.x authored by mglaman

Issue #2951353 by mglaman: Provide a Twig template and theme hook...

Comment #5

bojanz CreditAttribution: bojanz at Centarro commented 28 March 2018 at 12:31

Status:

Needs review

» Fixed

Thanks, this works fine!

Added an explicit #pane_id and used it in the suggestion hook, to allow checkout flows to add panes under a different parent (due to accordions, for example).