Due to how HtmlResponseAttachmentsProcessor::processHtmlHead works, if there are multiple inline css declarations with the same id only the last one will actually be rendered. This patch just gives each one generated by the Color CSS declaration field formatter a unique id.

CommentFileSizeAuthor
#4 2949882-multiple-css-declarations-per-page-3.patch569 bytesmortona2k
#2 2949882-multiple-css-declarations-per-page-2.patch582 bytesNickDickinsonWilde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NickWilde created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design for North Studio commented
Assigned: NickDickinsonWilde » Unassigned
Category: Feature request » Bug report
Status: Active » Needs review
FileSize
2949882-multiple-css-declarations-per-page-2.patch582 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2949882-multiple-css-declarations-per-page-2.patch, failed testing. View results

mortona2k’s picture

mortona2k CreditAttribution: mortona2k commented
FileSize
2949882-multiple-css-declarations-per-page-3.patch569 bytes

The fix worked, but the patch didn't apply. You may have previously modified the line break and trailing comma on the line.

Here's a new patch.

  • NickWilde committed dc5e776 on 8.x-2.x 
    Issue #2949882 by NickWilde, mortona2k: Color CSS declaration only...
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design for North Studio commented
Status: Needs work » Fixed

Thanks @mortona2k.
I know have (co)maintainership so I'm committing a whole slew of stuff. Including this :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.