In the fivestar_form() function, there is a call to set

$settings['text'] => variable_get('fivestar_text_' . $node->type, 'combo')

I believe that string 'combo' should instead be 'dual', based upon the values that are defined for the "Text display style" found in fivestar_form_alter(). There is one other instance similar to this in fivestar_views_widget_hander(), but I'm not as confident in my assessment there since I haven't really been looking at that code.

#1 fivestar294870.patch1.3 KBvladimir.dolgopolov


vladimir.dolgopolov’s picture

Status: Active » Needs review
1.3 KB

I agree with you. There is a confusion between "dual" and "combo".
"Combo" used in CSS and XML here so I think "combo" should be replaced totally.
But the patch fixes only fivestar_text_* variable.

quicksketch’s picture

Status: Needs review » Fixed

Thanks again vladimir! I committed your fix, much appreciated!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.