Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In the fivestar_form() function, there is a call to set
$settings['text'] => variable_get('fivestar_text_' . $node->type, 'combo')
I believe that string 'combo' should instead be 'dual', based upon the values that are defined for the "Text display style" found in fivestar_form_alter(). There is one other instance similar to this in fivestar_views_widget_hander(), but I'm not as confident in my assessment there since I haven't really been looking at that code.
Comment | File | Size | Author |
---|---|---|---|
#1 | fivestar294870.patch | 1.3 KB | vladimir.dolgopolov |
Comments
Comment #1
vladimir.dolgopolov CreditAttribution: vladimir.dolgopolov commentedI agree with you. There is a confusion between "dual" and "combo".
"Combo" used in CSS and XML here so I think "combo" should be replaced totally.
But the patch fixes only fivestar_text_* variable.
Comment #2
quicksketchThanks again vladimir! I committed your fix, much appreciated!
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.