Object.values() function is not supported on IE 11 and older versions of Google Chrome
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global...

A lot of our clients still use Windows XP with Google Chrome 49 installed (latest available for Win XP). So they have problems after upgrading theme to bootstrap-3.10.

CommentFileSizeAuthor
#2 object-values-fix-2948623.patch1.13 KBf1mishutka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

f1mishutka created an issue. See original summary.

f1mishutka’s picture

f1mishutka CreditAttribution: f1mishutka as a volunteer commented
Status: Active » Needs review
FileSize
object-values-fix-2948623.patch1.13 KB

My proposal: do not use Object.values() function in JS code (I've found 2 places)

P.S.: I hate IE too. And I do not like clients that use old Google Chrome versions and forcing us to support them.
But that is reality :(

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: f1mishutka » Unassigned
Issue tags: -JS, -Object.values

Link provided is for Array.prototype.values, not Object.values. Regardless, https://caniuse.com/#feat=object-values provides a better understanding of how saturated this feature is.

A lot of our clients still use Windows XP

Even Microsoft stopped supporting Windows XP... 4 years ago...

This isn't just a matter of updating to a modern browser. They should upgrade their whole computer which, coincidentally, will come with a newer browser :D

  • markcarver committed 8ccb043 on 8.x-3.x authored by f1mishutka 
    Issue #2948623 by f1mishutka: Object.values() function is not supported...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Fixed
f1mishutka’s picture

f1mishutka CreditAttribution: f1mishutka as a volunteer commented

This isn't just a matter of updating to a modern browser. They should upgrade their whole computer which, coincidentally, will come with a newer browser :D

Mark, I don't think there are any developers who like IE or old browsers for web development or even for surfing. But we are talking about clients.

One of our customers has ~20 computers under Windows XP (they use very old software and have compatibility problems even under Windows 7). And we want to sell them our service (it based on Drupal 8 and Bootstrap theme). And I can not tell to the customers "You guys stupidos. You have to buy 20 new computers with licenses and all the stuff and solve your old software compatibility problems after that just to try our services". So I tell them very gently "You have very old browser. This is very bad practice and really unsafe. Please, consider some ways to upgrade." And after that I should provide them a way to work with our system using their current environment for them be able at least to try how good we are for them.

Anyway thank you very much for developing Bootstrap theme! Really appreciate your work!

P.S.: Can't wait to try Bootstrap 4 for Drupal 8 :)

f1mishutka’s picture

f1mishutka CreditAttribution: f1mishutka as a volunteer commented
Status: Fixed » Closed (fixed)
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented

By the way, the same issue can be reproduced in iPhone / iPad. This is not only IE issue.
Anyway, thanks for the patch ;)

f1mishutka’s picture

f1mishutka CreditAttribution: f1mishutka as a volunteer commented

By the way, the same issue can be reproduced in iPhone / iPad. This is not only IE issue.

Yes, this function was not supported on iOS before March 2017: http://prntscr.com/ildfnk