Refactor \Drupal\Tests\views\Kernel\ModuleTest::testViewsGetHandler

The debug function was removed in #2212081: Remove views optional handler handling, so it is safe to assume this code is no longer needed.

Well it was commented out in #1822048: Introduce a generic fallback plugin mechanism.

It'd be great to get a +1 from a sub system maintainer. I think this is the right thing to do after reading #2212081: Remove views optional handler handling.

Testbot Snafu.

Still waiting for the subsystem maintainer review.

These tests should be in, because they test the 'Broken/Missing handler' UI text that you get when there's a problem.

So what we should do here, I think, is try removing the return, see what happens. I suspect the text the test is checking for will need tweaking, as BrokenHandlerTrait doesn't quite have the same text.

New patch with different approach - refactoring of test code

- added testing of messages from \Drupal\views\Plugin\views\BrokenHandlerTrait cos there's no actual testing of the trait and #2212081-24: Remove views optional handler handling tells about it
- extended tests for broken handler for both cases - when table is broken and when field is broken

Not sure it needs subsytem maintainer review

The does not apply for 9.1, therefore a reroll is needed.

Rerolled patch for 9.1.x, please review.

Setting it to NR and removing needs reroll tage.

The reroll looks good, just one nitpick:

+++ b/core/modules/views/tests/src/Kernel/ModuleTest.php
@@ -2,14 +2,19 @@
 
 class ModuleTest extends ViewsKernelTestBase {

The empty line before the class statement needs to go.

Updated patch as per the changes mentioned in #20, please review.

Hi @daffie,

Just removed empty line before the class statement, Thanks for the review.

Hi @mrinalini9,

apologize for the inconvenience patch IS not updated one day, that why I picked and updated.

Hi @shaktik,
I have already rerolled patch in #17, and also today, I am able to apply the same patch after taking the latest pull from the branch. So I don't think any update was needed. Can you please add interdiff file here.
Thanks

@mrinalini9: thank you for the patch.

@shaktik: Please post an interdiff.txt with your patch.

Hi @daffie, @mrinalini9,

below the interdiff as feedback on #20.

@@ -15,7 +15,6 @@
  *
  * @group views
  */
-
 class ModuleTest extends ViewsKernelTestBase {
 
   /**

Hi @shaktik,
I have already done these changes in #22 and I think both #22 and #23 are the same patches, I didn't found any differences between them.
Thanks

This looks great. No overlap with existing coverage, so refactoring this looks like the better solution then removing it.

The current scope here is just to refactor the old test, but we should probably extend the coverage for this to also include sort and argument:

• \Drupal\views\Plugin\views\sort\Broken
• \Drupal\views\Plugin\views\argument\Broken

But I'm fine with it if people want to move that to a follow up.

Created the requested followup: #3144679: The test \Drupal\Tests\views\Kernel\ModuleTest::testViewsGetHandler() is missing testing for \Drupal\views\Plugin\views\sort\Broken and \Drupal\views\Plugin\views\argument\Broken.

Committed and pushed 0c700b50a0 to 9.1.x and bf8bbd989e to 9.0.x and ebbda37025 to 8.9.x. Thanks!

Backported to 8.9.x as a test only change.