Problem/Motivation

In updating to jQuery UI 1.12.1 in #2809427: Update jQuery UI to 1.12, some icons are removed from /core/assets/vendor/jquery.ui/themes/base/ -
see http://cgit.drupalcode.org/drupal/commit?h=8.4.x&id=e05bab84bb42b3ccaaa0...
This is problematic for updating to sites but ah well, the main problem, is that Seven theme references some (at least) one of those icons in multiple places.

Proposed resolution

There are a couple possible resolutions:
1. change any references to the removed iconsets to use one of the other icon sets
2. re-add the removed icon set colours.

In many ways I believe #1 is preferable.

Known problem lines (as of release 8.4.4):
web/core/themes/seven/css/components/jquery.ui/theme.css - lines 65 & 69

Remaining tasks

Method of resolution has to be chosen and acted upon.

Comments

NickWilde created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Issue summary: View changes
imAliAzhar’s picture

imAliAzhar CreditAttribution: imAliAzhar as a volunteer and commented

The lines 67, 68 as well as 72,77, 80 and 84 of web/core/themes/seven/css/components/jquery.ui/theme.css refer to icons in web/core/themes/seven/images/ which have not been removed by the linked patch (#2809427: Update jQuery UI to 1.12)

The seven theme still maintains a copy of the removed icons in web/core/themes/seven/images

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Issue tags: +JavaScript, +CSS
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Component: Seven theme » base system
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Active » Closed (works as designed)

@imAliAzhar You were right. I should've read that better - it is fine in core. I just had a custom theme that was using a different icon set overriding that one and didn't see the slight difference in paths. Thanks!
Sorry for the noise everyone.