Please add a roadmap to the help page.

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

Assigned: volkswagenchick » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.8 KB

I uploaded a patch the added a roadmap to the help page

daggerhart’s picture

Status: Needs review » Needs work

This is looking great! I really like the plan to provide the roadmap on the module's help page. I'm going to try to work this idea into some other modules.

There are a few minor coding standards issues in the patch.

  1. +++ b/admin_status.module
    @@ -8,7 +8,7 @@
    +function admin_status_help($route_name) { ¶
    

    There is an extra trailing space at the end of this line causing it to not meet the Drupal 8 coding standard: "Lines should have no trailing whitespace at the end."

  2. +++ b/admin_status.module
    @@ -20,8 +20,13 @@ function admin_status_help($route_name) {
    -
    

    The deletion of this line breaks the coding standard: "Case breaking statements must be followed by a single blank line".

Interestingly enough, the 2nd code smell is not documented on the Drupal coding standards page. I've submitted a comment on the discuss page with all the details, and asked if it should be included.

dhruveshdtripathi’s picture

Status: Needs work » Needs review
StatusFileSize
new1.16 KB

Made changes suggested in comment #3

Patch attached with the changes.

emartoni’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +#ciandt-contrib
StatusFileSize
new44.04 KB
new95.42 KB

Patch applied!

Looks good and I liked the roadmap entry on help.

cehfisher’s picture

Patch in #4 applied well on simplytest.me. Think we are good to go!

loopduplicate’s picture

Status: Reviewed & tested by the community » Fixed

Thanks :)

loopduplicate’s picture

Crediting everyone who helped.

volkswagenchick’s picture

Thanks to everyone who helped with this issue at Florida Drupal Camp

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.