Closed (fixed)
Project:
Admin Status
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Feb 2018 at 16:38 UTC
Updated:
20 Mar 2018 at 01:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
volkswagenchickI uploaded a patch the added a roadmap to the help page
Comment #3
daggerhart commentedThis is looking great! I really like the plan to provide the roadmap on the module's help page. I'm going to try to work this idea into some other modules.
There are a few minor coding standards issues in the patch.
There is an extra trailing space at the end of this line causing it to not meet the Drupal 8 coding standard: "Lines should have no trailing whitespace at the end."
The deletion of this line breaks the coding standard: "Case breaking statements must be followed by a single blank line".
Interestingly enough, the 2nd code smell is not documented on the Drupal coding standards page. I've submitted a comment on the discuss page with all the details, and asked if it should be included.
Comment #4
dhruveshdtripathi commentedMade changes suggested in comment #3
Patch attached with the changes.
Comment #5
emartoni commentedPatch applied!
Looks good and I liked the roadmap entry on help.
Comment #6
cehfisher commentedPatch in #4 applied well on simplytest.me. Think we are good to go!
Comment #8
loopduplicate commentedThanks :)
Comment #9
loopduplicate commentedCrediting everyone who helped.
Comment #10
volkswagenchickThanks to everyone who helped with this issue at Florida Drupal Camp