Although it's written in the module README.txt, it's not very clear that the Range Widget depends on a the jQuery-UI Slider-Pips library to render correctly.
I propose to:

  1. Write it down in the module description (at least it's clear for every kind of user)
  2. Run a basic check on install, and optionally display an warning on the status report page

I will write down a patch if ok.

CommentFileSizeAuthor
#3 2942558.patch1.4 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elgandoz created an issue. See original summary.

borisson_’s picture

Issue tags: -Libraries

Checking this on install of the submodule is a great idea. Not sure if the module description is a good idea. I like that the webform module provides a message on the status page for these kinds of libraries. I think we should do something like that as well.

In any case, thank you so much for bringing this up and offering to write a patch. Very much looking forward to seeing that.

PS: It seems you (like many others – it's really easy to misinterpret) are confused by the "Issue tags" field. As the guidelines state, they aren't meant for free text tags related to the issue, but only for specific categorization purposes, usually by module maintainers.
So, if you aren't sure your current usage is correct, please just leave the field empty.

borisson_’s picture

Status: Active » Needs review
FileSize
1.4 KB
StryKaizer’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, moving it to .module to show this error also in status report page, and committing

  • StryKaizer committed fa65edc on 8.x-1.x authored by borisson_
    Issue #2942558 by borisson_, StryKaizer: Facets Range Widget needs...
StryKaizer’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.