The "administer image metadata" permission is also used by the EXIF module, so the one for EXIF Custom should be renamed.

CommentFileSizeAuthor
#7 exif_custom-n2942055-7.interdiff.txt2.04 KBDamienMcKenna
#7 exif_custom-n2942055-7.patch3.04 KBDamienMcKenna
#5 exif_custom-rename-permission-2942055-D7.patch3.04 KBioana apetri
#2 exif_custom-rename_permission-2942055-D7.patch2.19 KBioana apetri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Status: Active » Needs review
FileSize
exif_custom-rename_permission-2942055-D7.patch2.19 KB

The renamed permission is done. Please check. thanks

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

Thanks for taking the time to put that together!

I think it could be just "administer exif_custom". And we'll need an update script to assign the new permission to everyone who had the old permission.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Assigned: Unassigned » ioana apetri
ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Status: Needs work » Needs review
FileSize
exif_custom-rename-permission-2942055-D7.patch3.04 KB

Here are the changes.

Status: Needs review » Needs work

The last submitted patch, 5: exif_custom-rename-permission-2942055-D7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
Parent issue: » #2934029: Plan for EXIF Custom 7.x-1.21 release
FileSize
exif_custom-n2942055-7.patch3.04 KB
exif_custom-n2942055-7.interdiff.txt2.04 KB

Minor tweaks - the update script needed to go in the install file.

  • DamienMcKenna committed 779ea4d on 7.x-1.x authored by yo30 
    Issue #2942055 by yo30, DamienMcKenna: 'Administer' permission clashes...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Committed. Still need a change record.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

nice work, warrants a new release?
Change record? like in changelog.txt ?
or documentation elsewhere?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Issue tags: -Needs change record

The "add change notice" link on the side, like this: https://www.drupal.org/node/2955848

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Nice work, I thought official change records were only for core, so ya for contrib also, good to know, looks good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.