Add Change record to @deprecated in core/lib/Drupal/Core/Session/AccountInterface.php

CommentFileSizeAuthor
#3 add_change_record-2940027-3.patch650 bytesjmsosso

Comments

jmsosso created an issue. See original summary.

jmsosso’s picture

jmsosso commented

Me and @jpmelguizo are going to work in this issue for the Sprint weekend 2018.

jmsosso’s picture

jmsosso commented
Status: Active » Needs review
StatusFileSize
new add_change_record-2940027-3.patch650 bytes

We added the CR linked to the issue that added the @deprecated tag but IMHO is not clear enough about the getUsername() deprecation. In the issue #2112679-178: getUsername() should return the username getDisplayName() for the formatted user name they discussed about changing the method name apart from the functionality.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +ContributionWeekend2019

Patch applies clean in latest -dev. I think it's ready to commit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I updated https://www.drupal.org/node/2572493 to mention getUserName() is deprecated.

Committed and pushed 6b6bc91784 to 8.7.x and fa7196c9b1 to 8.6.x. Thanks!

Backported to 8.6.x since this is a docs fix.

  • alexpott committed 6b6bc91 on 8.7.x 
    Issue #2940027 by jmsosso: Add change record to @deprecated for...

  • alexpott committed fa7196c on 8.6.x 
    Issue #2940027 by jmsosso: Add change record to @deprecated for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.