Node links always load the default revision during rendering

This blocks #2860097: Ensure that content translations can be moderated independently.

This happens because the #lazy_builder entry does not include the revision ID

I love how #lazy_builder makes the inputs EXPLICIT, which is why it's simple to explain and fix :)

+++ b/core/modules/node/src/NodeViewBuilder.php
@@ -89,7 +92,10 @@ public static function renderLinks($node_entity_id, $view_mode, $langcode, $is_i
+      $storage = \Drupal::entityTypeManager()->getStorage('node');

We can replace this with $this->entityManager->getStorage().

(This is a service injected into the parent class.)

I tried running the test without the code changes, and … it still passed. We need a failing test-only patch.

Also reviewed the test coverage, found only nits:

1. +++ b/core/modules/node/tests/src/Kernel/NodeViewBuilderTest.php
   @@ -0,0 +1,104 @@
   +   * Modules to enable.
   

   Nit: Just {@inheritdoc}.

2. +++ b/core/modules/node/tests/src/Kernel/NodeViewBuilderTest.php
   @@ -0,0 +1,104 @@
   +    // Create the node bundles required for testing.
   

   Nit: Seems extraneous to mention?

3. +++ b/core/modules/node/tests/src/Kernel/NodeViewBuilderTest.php
   @@ -0,0 +1,104 @@
   +    $output = $this->renderer->renderPlain($build)->__toString();
   

   Nit: I think (string) is cleaner — and we use that in most tests.

Assuming the test-only patch fails, this is ready. The actual code changes are beautifully simple!

Only failed because #12 has the failing test-only patch after the passing fix+tests patch.

Looks great. Adding reviewer credit.

Pushed to 8.6.x and 8.5.x.

Closed #2827913: hook_node_links_alter() always receives most recent revision of entity as a duplicate, adding credit.