Typo in this file under migration_dependencies; require should be required.

CommentFileSizeAuthor
#5 2939526-5.patch11.85 KBheddn
#2 2939526-Typo-in-migrate_plus.migration.wine_variety_list.yml.txt-example.patch554 bytesdavewilly
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davewilly created an issue. See original summary.

davewilly’s picture

davewilly CreditAttribution: davewilly as a volunteer commented
FileSize
2939526-Typo-in-migrate_plus.migration.wine_variety_list.yml.txt-example.patch554 bytes
Frank Ralf’s picture

Frank Ralf CreditAttribution: Frank Ralf commented

In addition, shouldn't the .txt file extension be stripped from the file name?

davewilly’s picture

davewilly CreditAttribution: davewilly commented

I am not sure of the reasoning for the file being .txt, assumed it may have been work in progress.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Title: Typo in migrate_plus.migration.wine_variety_list.yml.txt example » Unused migrate_plus.migration.wine_variety_list.yml.txt example + test fixes
Assigned: davewilly » Unassigned
Status: Active » Needs review
Issue tags: -typo
FileSize
2939526-5.patch11.85 KB

This is actually more than just a typo. That entire file was a vestige of a feature set that wasn't finished around xml paging. Let's remove it until we are ready to re-add it, if we ever do. We've figured out other ways to do what it was trying to do so it might never see the light of day.

While working figuring this out, I enabled more modules in our test coverage. So this patch also has some test fixes.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

Test mainly changes here. Let's go to RTBC.

  • heddn committed 9f91a2b on 8.x-4.x 
    Issue #2939526 by davewilly, heddn, Frank Ralf: Unused migrate_plus....
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.