Problem/Motivation

I think the fields in the User migration for d6 (d6_user) are somewhat misleading considering it lists the profile fields (using drush migrate-fields-source) but are actually not accessible.

Proposed resolution

Remove the fields so it won't be listed as part of the source.

CommentFileSizeAuthor
#2 drupal-profile_fields-2939336-1.patch655 bytesdsdeiz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsdeiz created an issue. See original summary.

dsdeiz’s picture

dsdeiz CreditAttribution: dsdeiz commented
Status: Active » Needs review
FileSize
drupal-profile_fields-2939336-1.patch655 bytes

Patch attached.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +migrate-d6-d8

tagging

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Needs work

Are we sure that d6 user profile data isn't available? #2225959: D6 Users and User Profile data isn't migrating and others seem to indicate it is supported.

dsdeiz’s picture

dsdeiz CreditAttribution: dsdeiz commented

Not really sure, sorry. It doesn't seem to be available when I tested it. Unlike ProfileFieldValues which does seem to provide the data for profile fields.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review

@dsdeiz, thanks for the patch. Yes, the profile fields are not available on d6_user source plugin. Neither the query method or prepareRow add Profile fields to the row, it is only in the fields method that the fields from the profile table are added. So, yes that should be removed.

Retesting the patch.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Manually tested the patch, with the patch applied the profile fields are not listed and when it is not the profile fields are listed. So, all good to go.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-profile_fields-2939336-1.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review

Retesting, the failure is unrelated.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Assigned: Unassigned » quietone

Assigning to self for rvw

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Assigned: quietone » Unassigned
Status: Needs review » Reviewed & tested by the community

The recent test failure was unrelated and the patch was retested, within the past day, and passed tests.

Back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Committed and pushed 729b6308bc to 8.6.x and 6609757cc5 to 8.5.x. Thanks!

I think this is a bug - which shouldn't be listing fields that aren't migrated.

  • alexpott committed 729b630 on 8.6.x 
    Issue #2939336 by dsdeiz, quietone: D6 User Profile Source Fields

  • alexpott committed 6609757 on 8.5.x 
    Issue #2939336 by dsdeiz, quietone: D6 User Profile Source Fields

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.