Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
panopoly_magic has a special panopoly_magic_reusable_entity_validation()
validation callback, that's meant to validate that reusable FPP's have an "Admin Title". It doesn't fire, except when uploading an image to an FPP with an image field.
Comment | File | Size | Author |
---|---|---|---|
#3 | panopoly_magic-reusable-fpp-validation-2938996-3.patch | 1.28 KB | dsnopek |
Comments
Comment #2
dsnopekWow, this code is old! Apparently, it was originally added in #1772728: General Settings Options Get Jumbled (2012) and modified a little bit in #2307831: Using deprecated clicked_button, not triggering_element (2014)
Comment #3
dsnopekHere's a patch that works in my testing
EDIT: Here's a build on Travis https://travis-ci.org/panopoly/panopoly/builds/332513419
Comment #5
dsnopekCommitted!
Comment #7
aubjr_drupal CreditAttribution: aubjr_drupal commentedI had patched Panopoly Magic 1.53 with the patch from https://www.drupal.org/project/panopoly/issues/2813395#comment-12643970, but this patch introduced the issue again in Panopoly Magic 1.55 for my sites. I've applied that patch in Panopoly Magic v1.55, where it works as well.
Can someone review the logic in the #2813395 patch, along with the work wylbur did at https://www.drupal.org/project/panopoly/issues/2813395#comment-12754978?
Comment #8
aubjr_drupal CreditAttribution: aubjr_drupal commented