panopoly_magic has a special panopoly_magic_reusable_entity_validation() validation callback, that's meant to validate that reusable FPP's have an "Admin Title". It doesn't fire, except when uploading an image to an FPP with an image field.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Wow, this code is old! Apparently, it was originally added in #1772728: General Settings Options Get Jumbled (2012) and modified a little bit in #2307831: Using deprecated clicked_button, not triggering_element (2014)

dsnopek’s picture

Status: Active » Needs review
FileSize
1.28 KB

Here's a patch that works in my testing

EDIT: Here's a build on Travis https://travis-ci.org/panopoly/panopoly/builds/332513419

  • dsnopek committed 8f7d550 on 7.x-1.x
    Update Panopoly Magic for Issue #2938996 by dsnopek: Validation for...
dsnopek’s picture

Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

aubjr_drupal’s picture

I had patched Panopoly Magic 1.53 with the patch from https://www.drupal.org/project/panopoly/issues/2813395#comment-12643970, but this patch introduced the issue again in Panopoly Magic 1.55 for my sites. I've applied that patch in Panopoly Magic v1.55, where it works as well.

Can someone review the logic in the #2813395 patch, along with the work wylbur did at https://www.drupal.org/project/panopoly/issues/2813395#comment-12754978?

aubjr_drupal’s picture

Priority: Normal » Major